<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jan 12, 2015 at 6:10 PM, Richard Trieu <span dir="ltr"><<a href="mailto:rtrieu@google.com" target="_blank">rtrieu@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div id=":138" class="" style="overflow:hidden">+// Disable the warning that triggers on exactly what is being tested.<br>
+#<span class="">pragma</span> clang diagnostic push<br>
+#<span class="">pragma</span> clang diagnostic ignored "-Wself-<span class="">move</span>"</div></blockquote></div><br>Old clang's warn on this:</div><div class="gmail_extra">APIntTest.cpp:684:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]</div><div class="gmail_extra"><br></div><div class="gmail_extra">I think we should change this pragma warning to not fire when an unknown warning group is *ignored*, and only fire when an unknown warning group is *requested*. Would that make sense?</div></div>