<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jan 13, 2015 at 1:45 PM, Chandler Carruth <span dir="ltr"><<a href="mailto:chandlerc@google.com" target="_blank">chandlerc@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><span class=""><br><div class="gmail_quote">On Mon, Jan 12, 2015 at 6:10 PM, Richard Trieu <span dir="ltr"><<a href="mailto:rtrieu@google.com" target="_blank">rtrieu@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="overflow:hidden">+// Disable the warning that triggers on exactly what is being tested.<br>
+#<span>pragma</span> clang diagnostic push<br>
+#<span>pragma</span> clang diagnostic ignored "-Wself-<span>move</span>"</div></blockquote></div><br></span>Old clang's warn on this:</div><div class="gmail_extra">APIntTest.cpp:684:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]</div><div class="gmail_extra"><br></div><div class="gmail_extra">I think we should change this pragma warning to not fire when an unknown warning group is *ignored*, and only fire when an unknown warning group is *requested*. Would that make sense?</div></div></blockquote><div><br>Sonuds reasonable to me, though should we change the command line behavior to match (-Wno-foobar warns with clang, but doesn't warn (except when producing other errors?) with GCC)?<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div></div>