<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jan 6, 2015 at 4:30 PM, Tobias Grosser <span dir="ltr"><<a href="mailto:tobias@grosser.es" target="_blank">tobias@grosser.es</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: grosser<br>
Date: Tue Jan  6 18:30:01 2015<br>
New Revision: 225326<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=225326&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=225326&view=rev</a><br>
Log:<br>
Do not use a const Twine here<br>
<br>
This has caused segfaults when using Polly in the context of Julia, that are<br>
not reproducible on my machine in 'make check-polly'.<br>
<br>
Modified:<br>
    polly/trunk/lib/CodeGen/IslExprBuilder.cpp<br>
<br>
Modified: polly/trunk/lib/CodeGen/IslExprBuilder.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/polly/trunk/lib/CodeGen/IslExprBuilder.cpp?rev=225326&r1=225325&r2=225326&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/polly/trunk/lib/CodeGen/IslExprBuilder.cpp?rev=225326&r1=225325&r2=225326&view=diff</a><br>
==============================================================================<br>
--- polly/trunk/lib/CodeGen/IslExprBuilder.cpp (original)<br>
+++ polly/trunk/lib/CodeGen/IslExprBuilder.cpp Tue Jan  6 18:30:01 2015<br>
@@ -112,7 +112,7 @@ Value *IslExprBuilder::createAccessAddre<br>
   const ScopArrayInfo *SAI = ScopArrayInfo::getFromId(BaseId);<br>
   Base = SAI->getBasePtr();<br>
   assert(Base->getType()->isPointerTy() && "Access base should be a pointer");<br>
-  const Twine &BaseName = Base->getName();<br>
+  auto BaseName = Base->getName();<br></blockquote><div><br></div><div>So what type does getName return? StringRef?<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
   if (Base->getType() != SAI->getType())<br>
     Base = Builder.CreateBitCast(Base, SAI->getType(),<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>