<div dir="ltr">On Mon, Jan 5, 2015 at 10:27 AM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Mon, Jan 5, 2015 at 9:56 AM, Saleem Abdulrasool <span dir="ltr"><<a href="mailto:compnerd@compnerd.org" target="_blank">compnerd@compnerd.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: compnerd<br>
Date: Mon Jan  5 11:56:32 2015<br>
New Revision: 225186<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=225186&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=225186&view=rev</a><br>
Log:<br>
SymbolRewriter: use iplist::splice<br>
<br>
The swap implementation for iplist is currently unsupported.  Simply splice the<br>
old list into place, which achieves the same purpose.  This is needed in order<br>
to thread the -frewrite-map-file frontend option correctly.  NFC.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Transforms/Utils/SymbolRewriter.cpp<br>
<br>
Modified: llvm/trunk/lib/Transforms/Utils/SymbolRewriter.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/SymbolRewriter.cpp?rev=225186&r1=225185&r2=225186&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/SymbolRewriter.cpp?rev=225186&r1=225185&r2=225186&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Transforms/Utils/SymbolRewriter.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/Utils/SymbolRewriter.cpp Mon Jan  5 11:56:32 2015<br>
@@ -494,7 +494,7 @@ RewriteSymbols::RewriteSymbols() : Modul<br>
<br>
 RewriteSymbols::RewriteSymbols(SymbolRewriter::RewriteDescriptorList &DL)<br>
     : ModulePass(ID) {<br>
-  std::swap(Descriptors, DL);<br>
+  Descriptors.splice(Descriptors.begin(), DL);<br></blockquote></span><div><br>Could we just implement swap with splice, or does that not work?<br></div></div></div></div></blockquote><div><br></div><div>I can get away with it here, since I don't really care about the swap, merely that the contents of the provided list are moved over (cheaply).  Splice moves the range from one list to the other.  I suppose that we could use that and a temporary to do the swap.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div></div><span class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
 }<br>
<br>
 bool RewriteSymbols::runOnModule(Module &M) {<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></span></div><br></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Saleem Abdulrasool<br>compnerd (at) compnerd (dot) org</div>
</div></div>