<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Dec 23, 2014 at 9:20 AM, Rafael Espindola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rafael<br>
Date: Tue Dec 23 11:20:23 2014<br>
New Revision: 224773<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=224773&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=224773&view=rev</a><br>
Log:<br>
Fix a leak found by asan.<br>
<br>
Modified:<br>
    llvm/trunk/unittests/IR/WaymarkTest.cpp<br>
<br>
Modified: llvm/trunk/unittests/IR/WaymarkTest.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/IR/WaymarkTest.cpp?rev=224773&r1=224772&r2=224773&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/IR/WaymarkTest.cpp?rev=224773&r1=224772&r2=224773&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/unittests/IR/WaymarkTest.cpp (original)<br>
+++ llvm/trunk/unittests/IR/WaymarkTest.cpp Tue Dec 23 11:20:23 2014<br>
@@ -29,8 +29,9 @@ TEST(WaymarkTest, NativeArray) {<br>
   Value * values[22];<br>
   std::transform(tail, tail + 22, values, char2constant);<br>
   FunctionType *FT = FunctionType::get(Type::getVoidTy(getGlobalContext()), true);<br>
-  Function *F = Function::Create(FT, GlobalValue::ExternalLinkage);<br>
-  const CallInst *A = CallInst::Create(F, makeArrayRef(values));<br>
+  std::unique_ptr<Function> F(<br>
+      Function::Create(FT, GlobalValue::ExternalLinkage));<br></blockquote><div><br>I'm guessing there's no chance that Function::Create (& I guess, by extension, all the other <Instruction>::Create functions) should be changed to return std::unique_ptr?<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+  const CallInst *A = CallInst::Create(F.get(), makeArrayRef(values));<br>
   ASSERT_NE(A, (const CallInst*)nullptr);<br>
   ASSERT_EQ(1U + 22, A->getNumOperands());<br>
   const Use *U = &A->getOperandUse(0);<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>