<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Duncan,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Remind me why it's important to have the 'value' keyword? This bikeshed was<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">probably painted a while back but syntactically it doesn't seem too useful.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">It seems like you have (a) stuff starting with '!' is a metadata node/reference,
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">(b) everything else is a value (and must start with a type name). There's<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">probably something I'm forgetting, that made 'value' useful…<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">--paulr<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></a></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Eric Christopher [mailto:echristo@gmail.com]
<br>
<b>Sent:</b> Thursday, December 11, 2014 4:07 PM<br>
<b>To:</b> Duncan P. N. Exon Smith; Robinson, Paul<br>
<b>Cc:</b> llvm-commits<br>
<b>Subject:</b> Re: [PATCH] IR: Make metadata typeless in assembly<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Hi Duncan,<br>
<br>
Looking through the LangRef as requested :)<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<div>
<p class="MsoNormal">+ A metadata node is a structure-like constant without a type (when<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">+ referenced by ``call`` instructions, they use :ref:`metadata type<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">+ <t_metadata>`). For example: "``!{ value i32 0, !"test" }``". Unlike other<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">+ constants that are meant to be interpreted as part of the instruction<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">+ stream, metadata is a place to attach additional information such as debug<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">+ info.<o:p></o:p></p>
</div>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">This is fairly opaque wording. Honestly I'd prefer "a constant tuple without types". The last probably needs/wants rewording as well, it's just not fabulous. Perhaps even an actual separate section would work well for metadata now that
it's separate from the value hierarchy?<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">The rest of the changes look fairly mechanical given the new description of the format.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Thanks!<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">-eric<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">On Wed Dec 10 2014 at 10:42:34 PM Duncan P. N. Exon Smith <<a href="mailto:dexonsmith@apple.com">dexonsmith@apple.com</a>> wrote:<o:p></o:p></p>
<p class="MsoNormal"><br>
> On 2014 Dec 10, at 20:35, Robinson, Paul <<a href="mailto:Paul_Robinson@playstation.sony.com" target="_blank">Paul_Robinson@playstation.sony.com</a>> wrote:<br>
><br>
> Note: in case it's confusing, some of the testcase changes in the code<br>
> patch are killing newlines so the upgrade script can do it's magic.<br>
><br>
> That part really feels like a purely mechanical change that oughta be separate.<br>
> --paulr<br>
<br>
Thanks Paul, good point. Committed that in r224002.<br>
<br>
Attaching the rebased patch. Let me know if you have any comments on LangRef!<br>
<br>
<br>
><br>
> From: <a href="mailto:llvm-commits-bounces@cs.uiuc.edu" target="_blank">llvm-commits-bounces@cs.uiuc.edu</a> [mailto:<a href="mailto:llvm-commits-bounces@cs.uiuc.edu" target="_blank">llvm-commits-bounces@cs.uiuc.edu</a>] On Behalf Of Duncan P. N. Exon Smith<br>
> Sent: Wednesday, December 10, 2014 6:17 PM<br>
> To: llvm-commits<br>
> Subject: [PATCH] IR: Make metadata typeless in assembly<br>
><br>
> Now that `Metadata` is typeless, reflect that in the assembly.<br>
><br>
> There's really only one reasonably thing to do here: strip the<br>
> `metadata` type (except in arguments to `call` instructions, where it<br>
> still has meaning), and add the symmetric `value` keyword for all<br>
> metadata operands that bridge to `Value`.<br>
><br>
> I'm confident in the code changes (although obviously I'll relish any<br>
> criticism offered), but I'd love a review of `docs/LangRef.rst`. I<br>
> wasn't really sure how much exposition was appropriate, so I kept it<br>
> pretty simple.<br>
><br>
> Also, I wrote an upgrade script that handle all of the tests in llvm<br>
> after applying the main patch. It even handles much of cfe (doing<br>
> mostly the right thing with `CHECK` lines). I'll be attaching it the PR<br>
> after I make my commit, but feel free to spot-check its enormous result,<br>
> which I've attached as llvm-tests.patch. (I'll squash that in with the<br>
> code changes when I commit.)<br>
><br>
> Note: in case it's confusing, some of the testcase changes in the code<br>
> patch are killing newlines so the upgrade script can do it's magic.<br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><o:p></o:p></p>
</div>
</div>
</div>
</body>
</html>