<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Dec 9, 2014 at 12:07 PM, Hans Wennborg <span dir="ltr"><<a href="mailto:hans@chromium.org" target="_blank">hans@chromium.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This broke the MSVC build, see e.g. [1]. I suspect it is because MSVC<br>
(except recent versions) doesn't support LLVM_EXPORTED.</blockquote><div><br>I take it you meant LLVM_EXPLICIT?<br><br><br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> I tried<br>
removing those operator bool()'s, but there were more errors.<br>
<br>
Does your patch compile if you remove LLVM_EXPORTED? I suspect that<br>
might reveal the same problem on Mac/Linux.<br>
<br>
 - Hans<br>
<br>
 1. <a href="http://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/660/steps/runhooks/logs/stdio" target="_blank">http://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/660/steps/runhooks/logs/stdio</a></blockquote><div><br>Somewhat surprised that compiles anywhere, really... Curious.<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>