<div dir="ltr">But FeatureP8Vector disappeared. I just supposed that it was being used for testing, and got removed now and FeatureVSX got added to pwr8.<div>Is the fix bringing it back (reverting half of the patch), or changing the target to something other than power8-vector?</div><div><br></div><div>Thanks,</div><div><br></div><div> Filipe</div><div><br></div><div>P.S: I'll just wait for the patch, but got curious.</div><div><br></div></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature"> F<br></div></div>
<br><div class="gmail_quote">On Mon, Dec 8, 2014 at 6:15 PM, Bill Schmidt <span dir="ltr"><<a href="mailto:wschmidt@linux.vnet.ibm.com" target="_blank">wschmidt@linux.vnet.ibm.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Mon, 2014-12-08 at 15:40 -0800, Filipe Cabecinhas wrote:<br>
> Can you fix the tests too, please?<br>
> CodeGen/PowerPC/vsx-p8.ll started failing because it was using<br>
> power8-vector.<br>
><br>
</span>Ah, this would be fixed by adding FeatureP8Vector to Power8, which we<br>
should probably do ASAP. Bill, can you look into that tomorrow?<br>
<br>
Thanks,<br>
Bill<br>
<div class="HOEnZb"><div class="h5">><br>
><br>
> Thanks,<br>
><br>
><br>
> Filipe<br>
><br>
> F<br>
><br>
><br>
> On Mon, Dec 8, 2014 at 3:07 PM, Bill Seurer<br>
> <<a href="mailto:seurer@linux.vnet.ibm.com">seurer@linux.vnet.ibm.com</a>> wrote:<br>
> Author: seurer<br>
> Date: Mon Dec 8 17:07:12 2014<br>
> New Revision: 223709<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=223709&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=223709&view=rev</a><br>
> Log:<br>
> [PowerPC]Activate FeatureVSX for the Power target<br>
><br>
> This change activates FeatureVSX for Power 7 and Power 8 in<br>
> PPC.td.<br>
><br>
> <a href="http://reviews.llvm.org/D6570" target="_blank">http://reviews.llvm.org/D6570</a><br>
><br>
> Modified:<br>
> llvm/trunk/lib/Target/PowerPC/PPC.td<br>
><br>
> Modified: llvm/trunk/lib/Target/PowerPC/PPC.td<br>
> URL:<br>
> <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/PPC.td?rev=223709&r1=223708&r2=223709&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/PPC.td?rev=223709&r1=223708&r2=223709&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/lib/Target/PowerPC/PPC.td (original)<br>
> +++ llvm/trunk/lib/Target/PowerPC/PPC.td Mon Dec 8 17:07:12<br>
> 2014<br>
> @@ -104,9 +104,6 @@ def FeatureQPX : SubtargetFeature<<br>
> def FeatureVSX : SubtargetFeature<"vsx","HasVSX",<br>
> "true",<br>
> "Enable VSX<br>
> instructions",<br>
> [FeatureAltivec]>;<br>
> -def FeatureP8Vector : SubtargetFeature<"power8-vector",<br>
> "HasP8Vector", "true",<br>
> - "Enable POWER8 vector<br>
> instructions",<br>
> - [FeatureVSX,<br>
> FeatureAltivec]>;<br>
><br>
> def DeprecatedMFTB : SubtargetFeature<"", "DeprecatedMFTB",<br>
> "true",<br>
> "Treat mftb as<br>
> deprecated">;<br>
> @@ -119,6 +116,7 @@ def DeprecatedDST : SubtargetFeature<<br>
> // CMPB p6, p6x, p7 cmpb<br>
> // DFP p6, p6x, p7 decimal floating-point<br>
> instructions<br>
> // POPCNTB p5 through p7 popcntb and related<br>
> instructions<br>
> +// VSX p7 vector-scalar instruction<br>
> set<br>
><br>
> //===----------------------------------------------------------------------===//<br>
> // ABI Selection<br>
> //<br>
> @@ -303,7 +301,7 @@ def : ProcessorModel<"pwr6x", G5Model,<br>
> FeatureFPRND, Feature64Bit,<br>
> DeprecatedMFTB, DeprecatedDST]>;<br>
> def : ProcessorModel<"pwr7", P7Model,<br>
> - [DirectivePwr7, FeatureAltivec,<br>
> + [DirectivePwr7, FeatureAltivec, FeatureVSX,<br>
> FeatureMFOCRF, FeatureFCPSGN,<br>
> FeatureFSqrt, FeatureFRE,<br>
> FeatureFRES, FeatureFRSQRTE,<br>
> FeatureFRSQRTES,<br>
> FeatureRecipPrec, FeatureSTFIWX,<br>
> FeatureLFIWAX,<br>
> @@ -312,7 +310,7 @@ def : ProcessorModel<"pwr7", P7Model,<br>
> Feature64Bit /*, Feature64BitRegs */,<br>
> DeprecatedMFTB, DeprecatedDST]>;<br>
> def : ProcessorModel<"pwr8", P7Model /* FIXME: Update to<br>
> P8Model when available */,<br>
> - [DirectivePwr8, FeatureAltivec,<br>
> + [DirectivePwr8, FeatureAltivec, FeatureVSX,<br>
> FeatureMFOCRF, FeatureFCPSGN,<br>
> FeatureFSqrt, FeatureFRE,<br>
> FeatureFRES, FeatureFRSQRTE,<br>
> FeatureFRSQRTES,<br>
> FeatureRecipPrec, FeatureSTFIWX,<br>
> FeatureLFIWAX,<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br>
<br>
</div></div></blockquote></div><br></div>