<div dir="ltr"><span style="font-size:13px">+; RUN: llvm-link %p/alignment.ll %p/Inputs/alignment.ll -S | FileCheck %s</span><br style="font-size:13px"><span style="font-size:13px">+; RUN: llvm-link %p/Inputs/alignment.ll %p/alignment.ll -S | FileCheck %s</span><br><div><span style="font-size:13px"><br></span></div><div><span style="font-size:13px">Is there a particular reason why we are testing both orders on the command line in this test? Should we do that in more tests?</span></div><div><span style="font-size:13px"><br></span></div><div><span style="font-size:13px">-- Sean Silva</span></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Dec 4, 2014 at 3:31 PM, Rafael Espindola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rafael<br>
Date: Thu Dec  4 17:31:21 2014<br>
New Revision: 223414<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=223414&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=223414&view=rev</a><br>
Log:<br>
Convert test to use an extra Input file. NFC.<br>
<br>
Added:<br>
    llvm/trunk/test/Linker/Inputs/alignment.ll<br>
    llvm/trunk/test/Linker/alignment.ll<br>
Removed:<br>
    llvm/trunk/test/Linker/2006-06-15-GlobalVarAlignment.ll<br>
<br>
Removed: llvm/trunk/test/Linker/2006-06-15-GlobalVarAlignment.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Linker/2006-06-15-GlobalVarAlignment.ll?rev=223413&view=auto" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Linker/2006-06-15-GlobalVarAlignment.ll?rev=223413&view=auto</a><br>
==============================================================================<br>
--- llvm/trunk/test/Linker/2006-06-15-GlobalVarAlignment.ll (original)<br>
+++ llvm/trunk/test/Linker/2006-06-15-GlobalVarAlignment.ll (removed)<br>
@@ -1,8 +0,0 @@<br>
-; The linker should choose the largest alignment when linking.<br>
-<br>
-; RUN: echo "@X = global i32 7, align 8" | llvm-as > %t.2.bc<br>
-; RUN: llvm-as < %s > %t.1.bc<br>
-; RUN: llvm-link %t.1.bc %t.2.bc -S | FileCheck %s<br>
-; CHECK: align 8<br>
-<br>
-@X = weak global i32 7, align 4<br>
<br>
Added: llvm/trunk/test/Linker/Inputs/alignment.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Linker/Inputs/alignment.ll?rev=223414&view=auto" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Linker/Inputs/alignment.ll?rev=223414&view=auto</a><br>
==============================================================================<br>
--- llvm/trunk/test/Linker/Inputs/alignment.ll (added)<br>
+++ llvm/trunk/test/Linker/Inputs/alignment.ll Thu Dec  4 17:31:21 2014<br>
@@ -0,0 +1 @@<br>
+@X = global i32 7, align 8<br>
<br>
Added: llvm/trunk/test/Linker/alignment.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Linker/alignment.ll?rev=223414&view=auto" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Linker/alignment.ll?rev=223414&view=auto</a><br>
==============================================================================<br>
--- llvm/trunk/test/Linker/alignment.ll (added)<br>
+++ llvm/trunk/test/Linker/alignment.ll Thu Dec  4 17:31:21 2014<br>
@@ -0,0 +1,8 @@<br>
+; The linker should choose the largest alignment when linking.<br>
+<br>
+; RUN: llvm-link %p/alignment.ll %p/Inputs/alignment.ll -S | FileCheck %s<br>
+; RUN: llvm-link %p/Inputs/alignment.ll %p/alignment.ll -S | FileCheck %s<br>
+<br>
+; CHECK: @X = global i32 7, align 8<br>
+<br>
+@X = weak global i32 7, align 4<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>