<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Dec 5, 2014, at 3:24 PM, Hans Wennborg <<a href="mailto:hans@chromium.org" class="">hans@chromium.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><blockquote type="cite" class=""><blockquote type="cite" class="">! In D6471#14, @resistor wrote:<br class=""></blockquote>Can you update LowerSwitch.cpp to incorporate this optimization? Otherwise targets that rely on it are losing this functionality.<br class=""></blockquote><br class="">It seems LowerSwitch.cpp is already set up to exploit unreachable defaults, see the test in test/Transforms/LowerSwitch/2014-06-11-SwitchDefaultUnreachableOpt.ll<br class=""><br class="">I guess it's a choice of whether that's important, or if moving popular cases into the default is better. If it's the latter I'm happy to implement it.<br class=""><br class=""><a href="http://reviews.llvm.org/D6471" class="">http://reviews.llvm.org/D6471</a><br class=""></div></blockquote><br class=""></div><div>I don’t have any particular knowledge that LowerSwitch is doing something undesirable, I just wanted to make sure we aren’t losing existing functionality on that path.</div><div><br class=""></div><div>—Owen</div><div><br class=""></div></body></html>