<html dir="ltr">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style id="owaParaStyle" type="text/css">P {margin-top:0;margin-bottom:0;}</style>
</head>
<body ocsi="0" fpstyle="1">
<div style="direction: ltr;font-family: Tahoma;color: #000000;font-size: 10pt;">Ok, so going by the git-svn-id's it's r220360, r215169. Both look good to me but I'm not the code owner for this area. We don't seem to have an explicit code owner for this area
so it must be Chris Lattner.<a href="https://llvm.org/svn/llvm-project/llvm/trunk@215169" target="_blank"><br>
</a>
<div style="font-family: Times New Roman; color: #000000; font-size: 16px">
<hr tabindex="-1">
<div style="direction: ltr;" id="divRpF890827"><font color="#000000" face="Tahoma" size="2"><b>From:</b> Neeraj Badlani [neerajbadlani@gmail.com]<br>
<b>Sent:</b> 03 December 2014 17:47<br>
<b>To:</b> Daniel Sanders<br>
<b>Cc:</b> llvm-commits@cs.uiuc.edu; Tom Stellard (tom@stellard.net)<br>
<b>Subject:</b> Re: LLVM- release_35 backprt patch.<br>
</font><br>
</div>
<div></div>
<div>
<div dir="ltr">
<div>Hi , </div>
<div>Attached is got log from my local branch . I have highlighted two commits from which I cherry picked . </div>
<div><br>
</div>
<div>================================================================</div>
[llvm] git show 0cd299b<br>
commit 0cd299be0ca2af7a104c395e4300976512bd9757<br>
Author: Filipe Cabecinhas <<a href="mailto:me@filcab.net" target="_blank">me@filcab.net</a>><br>
Date: Wed Oct 22 02:16:06 2014 +0000<br>
<br>
Silence gcc's -Wcomment<br>
<br>
gcc's (4.7, I think) -Wcomment warning is not "as smart" as clang's and<br>
warns even if the line right after the backslash-newline sequence only has<br>
a line comment that starts at the beginning of the line.<br>
<br>
git-svn-id: <a href="https://llvm.org/svn/llvm-project/llvm/trunk@220360" target="_blank">
https://llvm.org/svn/llvm-project/llvm/trunk@220360</a> 91177308-0d34-0410-b5e6-96231b3b80d8<br>
<span style="background-color:rgb(255,255,0)"> (cherry picked from commit 8ff1b9820829cfccd9866c54269efee93d68d8b6)</span><br>
Signed-off-by: Neeraj Badlani <<a href="mailto:neerajbadlani@gmail.com" target="_blank">neerajbadlani@gmail.com</a>><br>
<div>================================================================</div>
<div><br>
</div>
<div>
<div>[llvm] git show edfc599</div>
<div>commit edfc599a28a0a8190f31c942017ee81f629f3866</div>
<div>Author: Gerolf Hoflehner <<a href="mailto:ghoflehner@apple.com" target="_blank">ghoflehner@apple.com</a>></div>
<div>Date: Thu Aug 7 23:19:55 2014 +0000</div>
<div><br>
</div>
<div> Fix for multi-line comment warning</div>
<div> </div>
<div> git-svn-id: <a href="https://llvm.org/svn/llvm-project/llvm/trunk@215169" target="_blank">
https://llvm.org/svn/llvm-project/llvm/trunk@215169</a> 91177308-0d34-0410-b5e6-96231b3b80d8</div>
<div> <span style="background-color:rgb(255,255,0)">(cherry picked from commit d0f88d538121f3e3d645aeed419803ee9a7d7da7)</span></div>
<div> Signed-off-by: Neeraj Badlani <<a href="mailto:neerajbadlani@gmail.com" target="_blank">neerajbadlani@gmail.com</a>></div>
</div>
<div><br>
</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Wed, Dec 3, 2014 at 9:39 AM, Daniel Sanders <span dir="ltr">
<<a href="mailto:Daniel.Sanders@imgtec.com" target="_blank">Daniel.Sanders@imgtec.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex">
CC'd the release manager (Tom Stellard). It would be good to merge this in too. It fixes the warnings about multiline comments caused by the backslashes at the end of lines.<br>
<br>
We normally use a tool to merge commits directly from the trunk. Could you tell Tom the revision numbers you created your patch from?<br>
<div class="HOEnZb">
<div class="h5"><br>
> -----Original Message-----<br>
> From: <a href="mailto:llvm-commits-bounces@cs.uiuc.edu" target="_blank">llvm-commits-bounces@cs.uiuc.edu</a> [mailto:<a href="mailto:llvm-commits-" target="_blank">llvm-commits-</a><br>
> <a href="mailto:bounces@cs.uiuc.edu" target="_blank">bounces@cs.uiuc.edu</a>] On Behalf Of Neeraj Badlani<br>
> Sent: 03 December 2014 15:33<br>
> To: <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
> Subject: LLVM- release_35 backprt patch.<br>
><br>
> Hi<br>
> I have just recently started learning LLVM , and during building of release_35<br>
> , I noticed couple of build errors .<br>
><br>
> Those have been corrected in the master , but have not been backported<br>
> yet to release_35 branch.<br>
><br>
> I cherry picked couple of commits from the master and applied to<br>
> release_35 .<br>
><br>
> Patch is attached in mail .<br>
><br>
> Since this is my first time submitting any patch in an open source<br>
> project , please let me know if I have done something wrong / can be<br>
> done better .<br>
><br>
><br>
> Thanks<br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</div>
</body>
</html>