<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<div class="moz-cite-prefix">On 12/01/2014 09:17 PM, Philip Reames
wrote:<br>
</div>
<blockquote cite="mid:547D4B78.8010401@philipreames.com" type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<div class="moz-cite-prefix">On 12/01/2014 07:18 PM, David Blaikie
wrote:<br>
</div>
<blockquote
cite="mid:CAENS6Esdk_FdZiVGxHztN2m9AEkaqwgxK5ZY3F97y7J_yY-99w@mail.gmail.com"
type="cite">
<p dir="ltr"><br>
On Dec 1, 2014 5:10 PM, "Nick Lewycky" <<a
moz-do-not-send="true" href="mailto:nicholas@mxc.ca">nicholas@mxc.ca</a>>
wrote:<br>
><br>
> Author: nicholas<br>
> Date: Mon Dec 1 19:09:56 2014<br>
> New Revision: 223101<br>
><br>
> URL: <a moz-do-not-send="true"
href="http://llvm.org/viewvc/llvm-project?rev=223101&view=rev">http://llvm.org/viewvc/llvm-project?rev=223101&view=rev</a><br>
> Log:<br>
> Fix variable used only in assertion.<br>
><br>
> Modified:<br>
> llvm/trunk/lib/Target/X86/X86MCInstLower.cpp<br>
><br>
> Modified: llvm/trunk/lib/Target/X86/X86MCInstLower.cpp<br>
> URL: <a moz-do-not-send="true"
href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86MCInstLower.cpp?rev=223101&r1=223100&r2=223101&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86MCInstLower.cpp?rev=223101&r1=223100&r2=223101&view=diff</a><br>
>
==============================================================================<br>
> --- llvm/trunk/lib/Target/X86/X86MCInstLower.cpp
(original)<br>
> +++ llvm/trunk/lib/Target/X86/X86MCInstLower.cpp Mon Dec
1 19:09:56 2014<br>
> @@ -816,8 +816,9 @@ static void
LowerSTATEPOINT(MCStreamer &<br>
> assert(Is64Bit && "Statepoint currently only
supports X86-64");<br>
><br>
> // We need to record the frame size for stack walking<br>
> - const MachineFunction* MF =
MI.getParent()->getParent();<br>
> + const MachineFunction *MF =
MI.getParent()->getParent();<br>
> assert(MF && "can't find machine function?");<br>
> + (void)MF;</p>
<p dir="ltr">Could we just roll the expression into the
assertion? Seems simple enough.</p>
</blockquote>
(This was originally my change.)<br>
<br>
I'll take a closer look tomorrow. I need to remind myself why the
assert is even needed if I'm not otherwise using the variable.
This may just be dead code. </blockquote>
This code was simply unnecessary. It survived a previous
refactoring when it shouldn't have. I deleted it. Sorry for the
noise.<br>
</body>
</html>