<div dir="ltr">This seems like a hand-written roll back change for r<span style="color:rgb(0,0,0)">222983. Before r</span><span style="color:rgb(0,0,0)">222983, the round-trip tests were confined in one #ifndef NDEBUG. Now it scattered across the file. Please roll r</span><span style="color:rgb(0,0,0)">222983</span><span style="color:rgb(0,0,0)"> back entirely to clean it up.</span><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Dec 1, 2014 at 12:28 PM, Shankar Easwaran <span dir="ltr"><<a href="mailto:shankare@codeaurora.org" target="_blank">shankare@codeaurora.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: shankare<br>
Date: Mon Dec  1 14:28:54 2014<br>
New Revision: 223073<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=223073&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=223073&view=rev</a><br>
Log:<br>
[Core] Remove function to not override RoundTripPasses.<br>
<br>
RoundTripPasses should always be called in DEBUG mode if the environment<br>
variable "LLD_RUN_ROUNDTRIP_TEST" is set.<br>
<br>
Flavors should not be able to override this behavior.<br>
<br>
Modified:<br>
    lld/trunk/include/lld/Core/LinkingContext.h<br>
    lld/trunk/lib/Core/LinkingContext.cpp<br>
<br>
Modified: lld/trunk/include/lld/Core/LinkingContext.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/Core/LinkingContext.h?rev=223073&r1=223072&r2=223073&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/Core/LinkingContext.h?rev=223073&r1=223072&r2=223073&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/include/lld/Core/LinkingContext.h (original)<br>
+++ lld/trunk/include/lld/Core/LinkingContext.h Mon Dec  1 14:28:54 2014<br>
@@ -319,10 +319,6 @@ public:<br>
   virtual uint64_t getNextOrdinalAndIncrement() const { return _nextOrdinal++; }<br>
<br>
 #ifndef NDEBUG<br>
-  void setRunRoundTripPass(bool roundTripPass) {<br>
-    _runRoundTripPasses = roundTripPass;<br>
-  }<br>
-<br>
   bool runRoundTripPass() const { return _runRoundTripPasses; }<br>
 #endif<br>
<br>
<br>
Modified: lld/trunk/lib/Core/LinkingContext.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Core/LinkingContext.cpp?rev=223073&r1=223072&r2=223073&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Core/LinkingContext.cpp?rev=223073&r1=223072&r2=223073&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/lib/Core/LinkingContext.cpp (original)<br>
+++ lld/trunk/lib/Core/LinkingContext.cpp Mon Dec  1 14:28:54 2014<br>
@@ -32,7 +32,7 @@ LinkingContext::LinkingContext()<br>
   llvm::Optional<std::string> env =<br>
       llvm::sys::Process::GetEnv("LLD_RUN_ROUNDTRIP_TEST");<br>
   if (env.hasValue() && !env.getValue().empty())<br>
-    setRunRoundTripPass(true);<br>
+    _runRoundTripPasses = true;<br>
 }<br>
 #else<br>
 LinkingContext::LinkingContext()<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>