<div dir="ltr">Ok one of the bots caught it with clang, but my local build passed. Weird.</div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Nov 29, 2014 at 7:20 PM, Craig Topper <span dir="ltr"><<a href="mailto:craig.topper@gmail.com" target="_blank">craig.topper@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ctopper<br>
Date: Sat Nov 29 19:20:17 2014<br>
New Revision: 222971<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=222971&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=222971&view=rev</a><br>
Log:<br>
Revert r222957 "Replace std::map<K, V*> with std::map<K, V> to handle ownership and deletion of the values."<br>
<br>
Upon further review I think the MultiClass is being copied into the map instead of being moved due to the copy constructor on the nested Record type. This ultimately got exposed when the vector in DefPrototype vector was changed to hold unique_ptrs in another commit. This caused gcc 4.7 to fail due to the use of the copy constructor on unique_ptr with the error pointing back to one of the insert calls from this commit. Not sure why clang was able to build.<br>
<br>
This reverts commit 710cdf729f84b428bf41aa8d32dbdb35fff79fde.<br>
<br>
Modified:<br>
llvm/trunk/lib/TableGen/TGParser.cpp<br>
llvm/trunk/lib/TableGen/TGParser.h<br>
<br>
Modified: llvm/trunk/lib/TableGen/TGParser.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/TableGen/TGParser.cpp?rev=222971&r1=222970&r2=222971&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/TableGen/TGParser.cpp?rev=222971&r1=222970&r2=222971&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/TableGen/TGParser.cpp (original)<br>
+++ llvm/trunk/lib/TableGen/TGParser.cpp Sat Nov 29 19:20:17 2014<br>
@@ -459,12 +459,12 @@ MultiClass *TGParser::ParseMultiClassID(<br>
return nullptr;<br>
}<br>
<br>
- auto it = MultiClasses.find(Lex.getCurStrVal());<br>
- if (it == MultiClasses.end())<br>
+ MultiClass *Result = MultiClasses[Lex.getCurStrVal()];<br>
+ if (!Result)<br>
TokError("Couldn't find multiclass '" + Lex.getCurStrVal() + "'");<br>
<br>
Lex.Lex();<br>
- return &it->second;<br>
+ return Result;<br>
}<br>
<br>
/// ParseSubClassReference - Parse a reference to a subclass or to a templated<br>
@@ -2290,13 +2290,11 @@ bool TGParser::ParseMultiClass() {<br>
return TokError("expected identifier after multiclass for name");<br>
std::string Name = Lex.getCurStrVal();<br>
<br>
- auto Result =<br>
- MultiClasses.insert(std::make_pair(Name,<br>
- MultiClass(Name, Lex.getLoc(),Records)));<br>
- if (!Result.second)<br>
+ if (MultiClasses.count(Name))<br>
return TokError("multiclass '" + Name + "' already defined");<br>
- CurMultiClass = &Result.first->second;<br>
<br>
+ CurMultiClass = MultiClasses[Name] = new MultiClass(Name,<br>
+ Lex.getLoc(), Records);<br>
Lex.Lex(); // Eat the identifier.<br>
<br>
// If there are template args, parse them.<br>
@@ -2557,9 +2555,8 @@ bool TGParser::ParseDefm(MultiClass *Cur<br>
// To instantiate a multiclass, we need to first get the multiclass, then<br>
// instantiate each def contained in the multiclass with the SubClassRef<br>
// template parameters.<br>
- auto it = MultiClasses.find(Ref.Rec->getName());<br>
- assert(it != MultiClasses.end() && "Didn't lookup multiclass correctly?");<br>
- MultiClass *MC = &it->second;<br>
+ MultiClass *MC = MultiClasses[Ref.Rec->getName()];<br>
+ assert(MC && "Didn't lookup multiclass correctly?");<br>
std::vector<Init*> &TemplateVals = Ref.TemplateArgs;<br>
<br>
// Verify that the correct number of template arguments were specified.<br>
<br>
Modified: llvm/trunk/lib/TableGen/TGParser.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/TableGen/TGParser.h?rev=222971&r1=222970&r2=222971&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/TableGen/TGParser.h?rev=222971&r1=222970&r2=222971&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/TableGen/TGParser.h (original)<br>
+++ llvm/trunk/lib/TableGen/TGParser.h Sat Nov 29 19:20:17 2014<br>
@@ -55,7 +55,7 @@ namespace llvm {<br>
class TGParser {<br>
TGLexer Lex;<br>
std::vector<std::vector<LetRecord> > LetStack;<br>
- std::map<std::string, MultiClass> MultiClasses;<br>
+ std::map<std::string, MultiClass*> MultiClasses;<br>
<br>
/// Loops - Keep track of any foreach loops we are within.<br>
///<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">~Craig</div>
</div>