<div dir="ltr">Hey Dave,<div><br></div><div>Should be fixed in r222864.</div><div><br></div><div>Cheers,</div><div>Lang.</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Nov 26, 2014 at 5:13 PM, Lang Hames <span dir="ltr"><<a href="mailto:lhames@gmail.com" target="_blank">lhames@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">It broke one of the MingGW bots (not Mips, apologies for that - I clearly need more sleep). See: <a href="http://bb.pgr.jp/builders/ninja-clang-x64-mingw64-RA/builds/5386" target="_blank">http://bb.pgr.jp/builders/ninja-clang-x64-mingw64-RA/builds/5386</a> :<div><span style="color:rgb(0,0,0);font-family:'Courier New',courier,monotype,monospace;white-space:pre-wrap"><br></span></div><div><span style="color:rgb(0,0,0);font-family:'Courier New',courier,monotype,monospace;white-space:pre-wrap">lib/ExecutionEngine/RuntimeDyld/CMakeFiles/LLVMRuntimeDyld.dir/GDBRegistrationListener.cpp.obj:GDBRegistrationListener.cpp:(.text+0x28b): undefined reference to `vtable for llvm::JITEventListener'</span><br></div><div><br></div><div>Now that I've had a chance to think about it, I think the problem is just that defining the anchor in ExecutionEngine (where it really does belong), then defining GDBRegistrationListener in RuntimeDyld is a layering violation: RuntimeDyld can't depend on ExecutionEngine. I'll move GDBRegistrationListener up to ExecutionEngine - that should fix this.</div><div><br></div><div>Cheers,</div><div>Lang.</div><div><br></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Nov 26, 2014 at 4:58 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Wed, Nov 26, 2014 at 4:15 PM, Lang Hames <span dir="ltr"><<a href="mailto:lhames@gmail.com" target="_blank">lhames@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: lhames<br>
Date: Wed Nov 26 18:15:28 2014<br>
New Revision: 222861<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=222861&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=222861&view=rev</a><br>
Log:<br>
[MCJIT] Remove JITEventListener's anchor until I can determine the right place<br>
to put it. This should unbreak the Mips bots.<br></blockquote></span><div><br>What was the problem with where it was?<br> </div><div><div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/ExecutionEngine/JITEventListener.h<br>
    llvm/trunk/lib/ExecutionEngine/ExecutionEngine.cpp<br>
<br>
Modified: llvm/trunk/include/llvm/ExecutionEngine/JITEventListener.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/JITEventListener.h?rev=222861&r1=222860&r2=222861&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/JITEventListener.h?rev=222861&r1=222860&r2=222861&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/ExecutionEngine/JITEventListener.h (original)<br>
+++ llvm/trunk/include/llvm/ExecutionEngine/JITEventListener.h Wed Nov 26 18:15:28 2014<br>
@@ -113,8 +113,6 @@ public:<br>
     return nullptr;<br>
   }<br>
 #endif // USE_OPROFILE<br>
-private:<br>
-  virtual void anchor();<br>
 };<br>
<br>
 } // end namespace llvm.<br>
<br>
Modified: llvm/trunk/lib/ExecutionEngine/ExecutionEngine.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/ExecutionEngine.cpp?rev=222861&r1=222860&r2=222861&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/ExecutionEngine.cpp?rev=222861&r1=222860&r2=222861&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/ExecutionEngine/ExecutionEngine.cpp (original)<br>
+++ llvm/trunk/lib/ExecutionEngine/ExecutionEngine.cpp Wed Nov 26 18:15:28 2014<br>
@@ -48,9 +48,6 @@ ExecutionEngine *(*ExecutionEngine::MCJI<br>
 ExecutionEngine *(*ExecutionEngine::InterpCtor)(std::unique_ptr<Module> M,<br>
                                                 std::string *ErrorStr) =nullptr;<br>
<br>
-// Anchor for the JITEventListener class.<br>
-void JITEventListener::anchor() {}<br>
-<br>
 ExecutionEngine::ExecutionEngine(std::unique_ptr<Module> M)<br>
   : EEState(*this),<br>
     LazyFunctionCreator(nullptr) {<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div></div><br></div></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>