<html><head></head><body>I'm not aware of any, but it seems best to avoid regressing functionality. I won't insist on this though.<br><br><div class="gmail_quote">On November 25, 2014 7:01:13 PM PST, Eric Christopher <echristo@gmail.com> wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br /><br /><div class="gmail_quote">On Tue Nov 25 2014 at 6:42:53 PM Peter Collingbourne <<a href="mailto:peter@pcc.me.uk">peter@pcc.me.uk</a>> wrote:<br /><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Wed, Nov 26, 2014 at 02:27:46AM -0000, Eric Christopher wrote:<br />
> +func SetMCJITOptimizationLevel(<u></u>options MCJITCompilerOptions, level uint) {<br />
> + options.C.OptLevel = C.uint(level)<br />
> +}<br />
<br />
This function has no effect, as 'options' is passed by value.<br />
<br />
This would be better as a method on the MCJITCompilerOptions type.<br />
The signature should look like this in order to pass 'options' by reference:<br />
<br />
func (options *MCJITCompilerOptions) SetOptLevel(level uint) { ... }<br />
<br />
We should also have setters for the other properties.<br /></blockquote><div><br /></div><div>Do we have users for the other properties yet? I'm not sure if we want to wrap things just because. Not objecting overly much, just curious.</div><div><br /></div><div>-eric</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br />
Thanks,<br />
--<br />
Peter<br />
</blockquote></div>
</blockquote></div><br>
-- <br>
Sent from my Android device with K-9 Mail. Please excuse my brevity.</body></html>