<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Nov 25, 2014 at 2:16 AM, Chandler Carruth <span dir="ltr"><<a href="mailto:chandlerc@google.com" target="_blank">chandlerc@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><span class=""><br><div class="gmail_quote">On Tue, Nov 25, 2014 at 1:49 AM, Marek Olsak <span dir="ltr"><<a href="mailto:marek.olsak@amd.com" target="_blank">marek.olsak@amd.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="overflow:hidden">Author: mareko<br>
Date: Tue Nov 25 03:49:23 2014<br>
New Revision: 222746<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=222746&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=222746&view=rev</a><br>
Log:<br>
R600/SI: <span>Disable</span> <span>commutativity</span> for MIN/MAX_LEGACY<br>
<br>
Modified:<br>
    llvm/trunk/lib/Target/R600/SIInstructions.td</div></blockquote></div><br></span>You seem to have not updated the tests:</div><div class="gmail_extra"><br></div><div class="gmail_extra"><a href="http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-debian-fast/builds/20003" target="_blank">http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-debian-fast/builds/20003</a><br></div><div class="gmail_extra"><br></div><div class="gmail_extra">Please fix or revert soon!</div></div>
</blockquote></div><br></div><div class="gmail_extra">OK, 30 minutes since my email and much longer since the first bot went red. I'm reverting this.</div><div class="gmail_extra"><br></div><div class="gmail_extra">Please watch the build bots and check that your changes don't break things before re-committing... =[</div></div>