<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">Yeah, I was looking for a function to close the file descriptor, but seem there's no such function, so I did this way. Does this really not exist? If so, I agree that we should add the function to llvm::sys::fs.</div><div class="gmail_quote"><br></div><div class="gmail_quote">On Tue, Nov 25, 2014 at 4:30 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="h5">On Tue, Nov 25, 2014 at 4:21 PM, Rui Ueyama <span dir="ltr"><<a href="mailto:ruiu@google.com" target="_blank">ruiu@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ruiu<br>
Date: Tue Nov 25 18:21:27 2014<br>
New Revision: 222799<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=222799&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=222799&view=rev</a><br>
Log:<br>
[PECOFF] Properly close a file descriptor.<br>
<br>
This was basically benign resource leak on Unix, but on Windows<br>
it could cause builds to fail because opened file descriptor<br>
prevents other processes from moving or removing the file.<br>
<br>
Modified:<br>
    lld/trunk/lib/ReaderWriter/PECOFF/PDBPass.h<br>
<br>
Modified: lld/trunk/lib/ReaderWriter/PECOFF/PDBPass.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/PECOFF/PDBPass.h?rev=222799&r1=222798&r2=222799&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/PECOFF/PDBPass.h?rev=222799&r1=222798&r2=222799&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/lib/ReaderWriter/PECOFF/PDBPass.h (original)<br>
+++ lld/trunk/lib/ReaderWriter/PECOFF/PDBPass.h Tue Nov 25 18:21:27 2014<br>
@@ -13,6 +13,12 @@<br>
 #include "lld/Core/Pass.h"<br>
 #include "llvm/ADT/StringRef.h"<br>
<br>
+#if !defined(_MSC_VER) && !defined(__MINGW32__)<br>
+#include <unistd.h><br>
+#else<br>
+#include <io.h><br>
+#endif<br>
+<br>
 namespace lld {<br>
 namespace pecoff {<br>
<br>
@@ -30,6 +36,7 @@ private:<br>
     int fd;<br>
     if (llvm::sys::fs::openFileForWrite(path, fd, llvm::sys::fs::F_Append))<br>
       llvm::report_fatal_error("failed to create a PDB file");<br>
+    ::close(fd);<br></blockquote></div></div><div><br>This seems asymmetric - using an llvm::sys::fs API to open it, but using the raw OS API to close? Should we roll this into llvm::sys::fs alongside the opening functions? </div><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
   }<br>
<br>
   PECOFFLinkingContext &_ctx;<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></span></div><br></div></div>
</blockquote></div><br></div></div>