<br><br><div class="gmail_quote">On Fri Nov 14 2014 at 11:07:18 AM David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Fri, Nov 14, 2014 at 10:44 AM, Eric Christopher <span dir="ltr"><<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: echristo<br>
Date: Fri Nov 14 12:44:53 2014<br>
New Revision: 222021<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=222021&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=222021&view=rev</a><br>
Log:<br>
Silence inconsistent override warnings.<br>
<br>
Modified:<br>
    lld/trunk/lib/ReaderWriter/ELF/SectionChunks.h<br>
<br>
Modified: lld/trunk/lib/ReaderWriter/ELF/SectionChunks.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/SectionChunks.h?rev=222021&r1=222020&r2=222021&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/SectionChunks.h?rev=222021&r1=222020&r2=222021&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/lib/ReaderWriter/ELF/SectionChunks.h (original)<br>
+++ lld/trunk/lib/ReaderWriter/ELF/SectionChunks.h Fri Nov 14 12:44:53 2014<br>
@@ -46,10 +46,10 @@ public:<br>
<br>
   /// \brief Modify the section contents before assigning virtual addresses<br>
   //  or assigning file offsets<br>
-  virtual void doPreFlight() {}<br>
+  virtual void doPreFlight() override {}<br></blockquote></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br>We usually just specify one of virtual, override, or final. I removed a few redundant virtuals (including these ones) in r222023.<br> </div></div></div></div></blockquote><div><br></div><div>Hey cool, thanks.</div><div><br></div><div>-eric</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
   /// \brief Finalize the section contents before writing<br>
-  virtual void finalize() {}<br>
+  virtual void finalize() override {}<br>
<br>
   /// \brief Does this section have an output segment.<br>
   virtual bool hasOutputSegment() {<br>
@@ -73,7 +73,7 @@ public:<br>
   Layout::SegmentType getSegmentType() const { return _segmentType; }<br>
<br>
   /// \brief Return the type of content that the section contains<br>
-  virtual int getContentType() const {<br>
+  virtual int getContentType() const override {<br>
     if (_flags & llvm::ELF::SHF_EXECINSTR)<br>
       return Chunk<ELFT>::ContentType::Code;<br>
     else if (_flags & llvm::ELF::SHF_WRITE)<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div></div></blockquote></div>