<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Nov 14, 2014 at 12:33 PM, Frederic Riss <span dir="ltr"><<a href="mailto:friss@apple.com" target="_blank">friss@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: friss<br>
Date: Fri Nov 14 14:33:40 2014<br>
New Revision: 222034<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=222034&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=222034&view=rev</a><br>
Log:<br>
COFF: Add support for Dwarf accelerator tables.<br>
<br>
This allows COFF targets to emit accelerator tables<br>
when requested by -dwarf-accel-tables=Enable instead<br>
of aborting. The test DebugInfo/cross-cu-inlining.ll<br>
covers this on COFF platforms.<br></blockquote><div><br>Usually if I find/fix actual bugs in platform-specific support for an otherwise platform-neutral test, I'll add explicit-triple tests for each of the platforms to demonstrate the fix. (in this instance, potentially leaving the .ll file in test/DebugInfo, but adding foo.test files in test/DebugInfo/X86, etc, with specified triples that exercise the interesting codepaths (ELF relocations, COFF sections, etc))<br><br>This way, the fix is demonstrated in a portable manner in the regression suite so that you or anyone else working on this won't break these unknowingly only to have the buildbots complain about it, etc... <br><br>Just a thought - opinions differ on this, certainly,<br><br>- David<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
    llvm/trunk/lib/MC/MCObjectFileInfo.cpp<br>
<br>
Modified: llvm/trunk/lib/MC/MCObjectFileInfo.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCObjectFileInfo.cpp?rev=222034&r1=222033&r2=222034&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCObjectFileInfo.cpp?rev=222034&r1=222033&r2=222034&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/MC/MCObjectFileInfo.cpp (original)<br>
+++ llvm/trunk/lib/MC/MCObjectFileInfo.cpp Fri Nov 14 14:33:40 2014<br>
@@ -781,6 +781,27 @@ void MCObjectFileInfo::InitCOFFMCObjectF<br>
                         COFF::IMAGE_SCN_MEM_READ,<br>
                         SectionKind::getMetadata());<br>
<br>
+  DwarfAccelNamesSection =<br>
+      Ctx->getCOFFSection(".apple_names",<br>
+                          COFF::IMAGE_SCN_MEM_DISCARDABLE |<br>
+                          COFF::IMAGE_SCN_MEM_READ,<br>
+                          SectionKind::getMetadata());<br>
+  DwarfAccelNamespaceSection =<br>
+      Ctx->getCOFFSection(".apple_namespaces",<br>
+                          COFF::IMAGE_SCN_MEM_DISCARDABLE |<br>
+                          COFF::IMAGE_SCN_MEM_READ,<br>
+                          SectionKind::getMetadata());<br>
+  DwarfAccelTypesSection =<br>
+      Ctx->getCOFFSection(".apple_types",<br>
+                          COFF::IMAGE_SCN_MEM_DISCARDABLE |<br>
+                          COFF::IMAGE_SCN_MEM_READ,<br>
+                          SectionKind::getMetadata());<br>
+  DwarfAccelObjCSection =<br>
+      Ctx->getCOFFSection(".apple_objc",<br>
+                          COFF::IMAGE_SCN_MEM_DISCARDABLE |<br>
+                          COFF::IMAGE_SCN_MEM_READ,<br>
+                          SectionKind::getMetadata());<br>
+<br>
   DrectveSection =<br>
     Ctx->getCOFFSection(".drectve",<br>
                         COFF::IMAGE_SCN_LNK_INFO |<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>