<div dir="ltr">For the record I looked at the diff produced by git-clang-format and seemed too big for a simple s/NULL/nullptr/ change. It would be nice if it had a mode of "only reformat if we overflowed 80cols".</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Nov 13, 2014 at 4:41 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: dblaikie<br>
Date: Thu Nov 13 18:41:42 2014<br>
New Revision: 221957<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=221957&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=221957&view=rev</a><br>
Log:<br>
Fix 80 cols caught by the linter...<br>
<br>
We have a linter running in our build now?<br>
<br>
Modified:<br>
    llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp<br>
    llvm/trunk/lib/Transforms/Instrumentation/MemorySanitizer.cpp<br>
<br>
Modified: llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp?rev=221957&r1=221956&r2=221957&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp?rev=221957&r1=221956&r2=221957&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp Thu Nov 13 18:41:42 2014<br>
@@ -1431,10 +1431,12 @@ void FunctionStackPoisoner::initializeCa<br>
         kAsanStackFreeNameTemplate + Suffix, IRB.getVoidTy(), IntptrTy,<br>
         IntptrTy, IntptrTy, nullptr));<br>
   }<br>
-  AsanPoisonStackMemoryFunc = checkInterfaceFunction(M.getOrInsertFunction(<br>
-      kAsanPoisonStackMemoryName, IRB.getVoidTy(), IntptrTy, IntptrTy, nullptr));<br>
-  AsanUnpoisonStackMemoryFunc = checkInterfaceFunction(M.getOrInsertFunction(<br>
-      kAsanUnpoisonStackMemoryName, IRB.getVoidTy(), IntptrTy, IntptrTy, nullptr));<br>
+  AsanPoisonStackMemoryFunc = checkInterfaceFunction(<br>
+      M.getOrInsertFunction(kAsanPoisonStackMemoryName, IRB.getVoidTy(),<br>
+                            IntptrTy, IntptrTy, nullptr));<br>
+  AsanUnpoisonStackMemoryFunc = checkInterfaceFunction(<br>
+      M.getOrInsertFunction(kAsanUnpoisonStackMemoryName, IRB.getVoidTy(),<br>
+                            IntptrTy, IntptrTy, nullptr));<br>
 }<br>
<br>
 void<br>
<br>
Modified: llvm/trunk/lib/Transforms/Instrumentation/MemorySanitizer.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Instrumentation/MemorySanitizer.cpp?rev=221957&r1=221956&r2=221957&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Instrumentation/MemorySanitizer.cpp?rev=221957&r1=221956&r2=221957&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Transforms/Instrumentation/MemorySanitizer.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/Instrumentation/MemorySanitizer.cpp Thu Nov 13 18:41:42 2014<br>
@@ -351,8 +351,9 @@ void MemorySanitizer::initializeCallback<br>
   MsanSetAllocaOrigin4Fn = M.getOrInsertFunction(<br>
     "__msan_set_alloca_origin4", IRB.getVoidTy(), IRB.getInt8PtrTy(), IntptrTy,<br>
     IRB.getInt8PtrTy(), IntptrTy, nullptr);<br>
-  MsanPoisonStackFn = M.getOrInsertFunction(<br>
-    "__msan_poison_stack", IRB.getVoidTy(), IRB.getInt8PtrTy(), IntptrTy, nullptr);<br>
+  MsanPoisonStackFn =<br>
+      M.getOrInsertFunction("__msan_poison_stack", IRB.getVoidTy(),<br>
+                            IRB.getInt8PtrTy(), IntptrTy, nullptr);<br>
   MsanChainOriginFn = M.getOrInsertFunction(<br>
     "__msan_chain_origin", IRB.getInt32Ty(), IRB.getInt32Ty(), nullptr);<br>
   MemmoveFn = M.getOrInsertFunction(<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>