<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">I see this as an intermediate step that will allow us to catch certain patterns. If performance tests show it is beneficial why not take it?<div class=""><br class=""></div><div class="">Enabling horizontal reductions is a second step that might subsume this logic.</div><div class=""><br class=""></div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Nov 12, 2014, at 8:33 AM, James Molloy <<a href="mailto:james@jamesmolloy.co.uk" class="">james@jamesmolloy.co.uk</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">Hi,<br class=""><br class="">This seems to me to be a sticking plaster over a bigger problem. This will fix some reductions, but the bigger problem of loops being unrolled and then not optimised still exists. I'd much prefer to see a solution to this problem than just adding more Elastoplast-logic to SLP.<br class=""><br class="">James<br class=""><div class="gmail_quote">On Wed, 12 Nov 2014 at 16:24 <a href="mailto:hfinkel@anl.gov" class="">hfinkel@anl.gov</a> <<a href="mailto:hfinkel@anl.gov" class="">hfinkel@anl.gov</a>> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">================<br class="">
Comment at: test/Transforms/SLPVectorizer/<u class=""></u>X86/return.ll:58<br class="">
@@ +57,3 @@<br class="">
+<br class="">
+attributes #0 = { nounwind readonly "less-precise-fpmad"="false" "no-frame-pointer-elim"="<u class=""></u>false" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "stack-protector-buffer-size"=<u class=""></u>"8" "unsafe-fp-math"="false" "use-soft-float"="false" }<br class="">
+<br class="">
----------------<br class="">
Please remove unnecessary attributes.<br class="">
<br class="">
================<br class="">
Comment at: test/Transforms/SLPVectorizer/<u class=""></u>X86/return.ll:62<br class="">
@@ +61,3 @@<br class="">
+<br class="">
+!0 = metadata !{metadata !"clang version 3.6.0 (221134)"}<br class="">
+!1 = metadata !{metadata !2, metadata !2, i64 0}<br class="">
----------------<br class="">
Please remove unnecessary metadata.<br class="">
<br class="">
<a href="http://reviews.llvm.org/D6227" target="_blank" class="">http://reviews.llvm.org/D6227</a><br class="">
<br class="">
<br class="">
<br class="">
______________________________<u class=""></u>_________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank" class="">llvm-commits@cs.uiuc.edu</a><br class="">
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank" class="">http://lists.cs.uiuc.edu/<u class=""></u>mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div>
</div></blockquote></div><br class=""></div></body></html>