<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">You’re right, I jumped the gun. Reversing your fix does nothing.<div class="">Sorry for the mistake!<br class=""><div class=""><br class=""></div><div class="">Sean</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Nov 6, 2014, at 2:53 PM, Frédéric Riss <<a href="mailto:friss@apple.com" class="">friss@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Nov 6, 2014, at 2:35 PM, Sean Callanan <<a href="mailto:scallanan@apple.com" class="">scallanan@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">The reference is not guaranteed to be a Value*, for LLDB, metadata can refer back to clang::NamedDecl*s.<div class="">This is breaking LLDB buildbots because printf() no longer works in LLDB:</div><div class=""><span class="Apple-tab-span" style="white-space:pre"> </span><a href="http://lab.llvm.org:8011/builders/lldb-x86_64-freebsd/builds/2513" class="">http://lab.llvm.org:8011/builders/lldb-x86_64-freebsd/builds/2513</a> (picked up clang 221471) is broken</div><div class=""><span class="Apple-tab-span" style="white-space:pre"> </span><a href="http://lab.llvm.org:8011/builders/lldb-x86_64-freebsd/builds/2512" class="">http://lab.llvm.org:8011/builders/lldb-x86_64-freebsd/builds/2512</a> (picked up clang 221467) is pretty clean</div><div class=""><div class="">We need to find a better way to solve this. In the meantime I am going to see if reverting this change makes LLDB happy again.</div></div></div></div></blockquote><div class=""><br class=""></div><div class="">I must be missing something. This revision only made the conversion to Value * explicit to help MSVC, but this conversion was already happening… </div><div class=""><br class=""></div><div class="">Fred</div><br class=""><blockquote type="cite" class=""><div class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><div class="">Sean<br class=""><div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Nov 6, 2014, at 11:00 AM, Frederic Riss <<a href="mailto:friss@apple.com" class="">friss@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">Author: friss<br class="">Date: Thu Nov 6 13:00:47 2014<br class="">New Revision: 221471<br class=""><br class="">URL: <a href="http://llvm.org/viewvc/llvm-project?rev=221471&view=rev" class="">http://llvm.org/viewvc/llvm-project?rev=221471&view=rev</a><br class="">Log:<br class="">Try to appease MSVC buildbots after r221466.<br class=""><br class="">Modified:<br class=""> llvm/trunk/lib/IR/DIBuilder.cpp<br class=""><br class="">Modified: llvm/trunk/lib/IR/DIBuilder.cpp<br class="">URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/DIBuilder.cpp?rev=221471&r1=221470&r2=221471&view=diff" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/DIBuilder.cpp?rev=221471&r1=221470&r2=221471&view=diff</a><br class="">==============================================================================<br class="">--- llvm/trunk/lib/IR/DIBuilder.cpp (original)<br class="">+++ llvm/trunk/lib/IR/DIBuilder.cpp Thu Nov 6 13:00:47 2014<br class="">@@ -194,7 +194,7 @@ DIImportedEntity DIBuilder::createImport<br class=""> unsigned Line, StringRef Name) {<br class=""> // Make sure to use the unique identifier based metadata reference for<br class=""> // types that have one.<br class="">- Value *V = Decl.isType() ? DIType(Decl).getRef() : Decl;<br class="">+ Value *V = Decl.isType() ? static_cast<Value*>(DIType(Decl).getRef()) : Decl;<br class=""> return ::createImportedModule(VMContext, dwarf::DW_TAG_imported_declaration,<br class=""> Context, V, Line, Name,<br class=""> AllImportedModules);<br class=""><br class=""><br class="">_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@cs.uiuc.edu" class="">llvm-commits@cs.uiuc.edu</a><br class=""><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" class="">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br class=""></div></blockquote></div><br class=""></div></div></div></div></div></blockquote></div><br class=""></div></div></blockquote></div><br class=""></div></div></body></html>