<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Committed in git-svn-id:
<a class="moz-txt-link-freetext" href="https://llvm.org/svn/llvm-project/lld/trunk@221433">https://llvm.org/svn/llvm-project/lld/trunk@221433</a> <br>
<br>
Thanks for your suggestion.<br>
<br>
Shankar Easwaran<br>
<br>
<br>
On 11/5/2014 9:00 PM, Shankar Easwaran wrote:<br>
</div>
<blockquote cite="mid:545AE458.1050502@codeaurora.org" type="cite">Thanks
David, Will give it a try.
<br>
<br>
On 11/5/2014 8:32 PM, David Blaikie wrote:
<br>
<blockquote type="cite">(oops, forgot to reply-all)
<br>
<br>
On Wed, Nov 5, 2014 at 6:32 PM, David Blaikie
<a class="moz-txt-link-rfc2396E" href="mailto:dblaikie@gmail.com"><dblaikie@gmail.com></a> wrote:
<br>
<br>
<blockquote type="cite">
<br>
On Wed, Nov 5, 2014 at 6:03 PM, Shankar Easwaran
<a class="moz-txt-link-rfc2396E" href="mailto:shankarke@gmail.com"><shankarke@gmail.com></a>
<br>
wrote:
<br>
<br>
<blockquote type="cite">Author: shankare
<br>
Date: Wed Nov 5 20:03:40 2014
<br>
New Revision: 221428
<br>
<br>
URL:
<a class="moz-txt-link-freetext" href="http://llvm.org/viewvc/llvm-project?rev=221428&view=rev">http://llvm.org/viewvc/llvm-project?rev=221428&view=rev</a>
<br>
Log:
<br>
[ELF] Use llvm::Twine
<br>
<br>
Modified:
<br>
lld/trunk/lib/ReaderWriter/ELF/ExecutableWriter.h
<br>
<br>
Modified: lld/trunk/lib/ReaderWriter/ELF/ExecutableWriter.h
<br>
URL:
<br>
<a class="moz-txt-link-freetext" href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/ExecutableWriter.h?rev=221428&r1=221427&r2=221428&view=diff">http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/ExecutableWriter.h?rev=221428&r1=221427&r2=221428&view=diff</a>
<br>
<br>
==============================================================================
<br>
--- lld/trunk/lib/ReaderWriter/ELF/ExecutableWriter.h
(original)
<br>
+++ lld/trunk/lib/ReaderWriter/ELF/ExecutableWriter.h Wed
Nov 5 20:03:40
<br>
2014
<br>
@@ -130,12 +130,8 @@ template <class ELFT> void
ExecutableWri
<br>
auto endAtomIter =
this->_layout.findAbsoluteAtom("end");
<br>
<br>
auto startEnd = [&](StringRef sym, StringRef sec)
-> void {
<br>
- // TODO: This looks like a good place to use Twine...
<br>
- std::string start("__"), end("__");
<br>
- start += sym;
<br>
- start += "_start";
<br>
- end += sym;
<br>
- end += "_end";
<br>
+ std::string start = (llvm::Twine("__", sym) +
"_start").str();
<br>
+ std::string end = (llvm::Twine("__", sym) +
"_end").str();
<br>
<br>
</blockquote>
Do you need the "Twine(" at all? I think const char * +
StringRef -> Twine
<br>
implicitly:
<br>
<br>
"__" + sym + "_end"
<br>
<br>
If that doesn't work, usually we just explicitly convert the
first operand
<br>
to Twine:
<br>
<br>
Twine("__") + sym + "_end"
<br>
<br>
rather than using Twine's concatenation operations directly.
<br>
<br>
<br>
<blockquote type="cite"> auto s =
this->_layout.findAbsoluteAtom(start);
<br>
auto e = this->_layout.findAbsoluteAtom(end);
<br>
auto section =
this->_layout.findOutputSection(sec);
<br>
<br>
<br>
_______________________________________________
<br>
llvm-commits mailing list
<br>
<a class="moz-txt-link-abbreviated" href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>
<br>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a>
<br>
<br>
</blockquote>
<br>
</blockquote>
<br>
<br>
_______________________________________________
<br>
llvm-commits mailing list
<br>
<a class="moz-txt-link-abbreviated" href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>
<br>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a>
<br>
</blockquote>
<br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
llvm-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a>
</pre>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation</pre>
</body>
</html>