<div dir="ltr">(oops, forgot to reply-all)</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Nov 5, 2014 at 6:32 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="h5">On Wed, Nov 5, 2014 at 6:03 PM, Shankar Easwaran <span dir="ltr"><<a href="mailto:shankarke@gmail.com" target="_blank">shankarke@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: shankare<br>
Date: Wed Nov  5 20:03:40 2014<br>
New Revision: 221428<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=221428&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=221428&view=rev</a><br>
Log:<br>
[ELF] Use llvm::Twine<br>
<br>
Modified:<br>
    lld/trunk/lib/ReaderWriter/ELF/ExecutableWriter.h<br>
<br>
Modified: lld/trunk/lib/ReaderWriter/ELF/ExecutableWriter.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/ExecutableWriter.h?rev=221428&r1=221427&r2=221428&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/ExecutableWriter.h?rev=221428&r1=221427&r2=221428&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/lib/ReaderWriter/ELF/ExecutableWriter.h (original)<br>
+++ lld/trunk/lib/ReaderWriter/ELF/ExecutableWriter.h Wed Nov  5 20:03:40 2014<br>
@@ -130,12 +130,8 @@ template <class ELFT> void ExecutableWri<br>
   auto endAtomIter = this->_layout.findAbsoluteAtom("end");<br>
<br>
   auto startEnd = [&](StringRef sym, StringRef sec) -> void {<br>
-    // TODO: This looks like a good place to use Twine...<br>
-    std::string start("__"), end("__");<br>
-    start += sym;<br>
-    start += "_start";<br>
-    end += sym;<br>
-    end += "_end";<br>
+    std::string start = (llvm::Twine("__", sym) + "_start").str();<br>
+    std::string end = (llvm::Twine("__", sym) + "_end").str();<br></blockquote><div><br></div></div></div><div>Do you need the "Twine(" at all? I think const char * + StringRef -> Twine implicitly:<br><br>"__" + sym + "_end"<br><br>If that doesn't work, usually we just explicitly convert the first operand to Twine:<br><br>Twine("__") + sym + "_end"<br><br>rather than using Twine's concatenation operations directly.</div><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
     auto s = this->_layout.findAbsoluteAtom(start);<br>
     auto e = this->_layout.findAbsoluteAtom(end);<br>
     auto section = this->_layout.findOutputSection(sec);<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></span></div><br></div></div>
</blockquote></div><br></div>