<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-GB" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">Hi,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">The O32 line needs an extra space but apart from that the alignment is only wrong in the email.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> llvm-commits-bounces@cs.uiuc.edu [mailto:llvm-commits-bounces@cs.uiuc.edu]
<b>On Behalf Of </b>Eric Christopher<br>
<b>Sent:</b> 30 October 2014 21:10<br>
<b>To:</b> Simon Atanasyan<br>
<b>Cc:</b> llvm-commits<br>
<b>Subject:</b> Re: [llvm] r220910 - [Mips] Add new Mips specific e_flags.<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal" style="margin-bottom:12.0pt">Right, doesn't look like it is aligned either. Could be wrong.
<o:p></o:p></p>
<div>
<p class="MsoNormal">On Thu, Oct 30, 2014, 2:08 PM Simon Atanasyan <<a href="mailto:simon@atanasyan.com">simon@atanasyan.com</a>> wrote:<o:p></o:p></p>
<p class="MsoNormal">One space between enum and the '=' conforms to our code-style but code<br>
around the changed lines align '=' in one column. That is why I<br>
selected such formatting style.<br>
<br>
On Fri, Oct 31, 2014 at 12:00 AM, Eric Christopher <<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>> wrote:<br>
> The formatting of the flags is weird. How about just one space between the<br>
> enum and the '='?<br>
><br>
> Thanks.<br>
><br>
> -eric<br>
><br>
> On Thu Oct 30 2014 at 8:12:11 AM Simon Atanasyan <<a href="mailto:simon@atanasyan.com" target="_blank">simon@atanasyan.com</a>><br>
> wrote:<br>
>><br>
>> Author: atanasyan<br>
>> Date: Thu Oct 30 09:56:02 2014<br>
>> New Revision: 220910<br>
>><br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=220910&view=rev" target="_blank">
http://llvm.org/viewvc/llvm-project?rev=220910&view=rev</a><br>
>> Log:<br>
>> [Mips] Add new Mips specific e_flags.<br>
>><br>
>> No functional changes.<br>
>><br>
>> Modified:<br>
>> llvm/trunk/include/llvm/Support/ELF.h<br>
>><br>
>> Modified: llvm/trunk/include/llvm/Support/ELF.h<br>
>> URL:<br>
>> <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/ELF.h?rev=220910&r1=220909&r2=220910&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/ELF.h?rev=220910&r1=220909&r2=220910&view=diff</a><br>
>><br>
>> ==============================================================================<br>
>> --- llvm/trunk/include/llvm/Support/ELF.h (original)<br>
>> +++ llvm/trunk/include/llvm/Support/ELF.h Thu Oct 30 09:56:02 2014<br>
>> @@ -876,7 +876,13 @@ enum : unsigned {<br>
>> EF_MIPS_ABI2 = 0x00000020,<br>
>> EF_MIPS_32BITMODE = 0x00000100,<br>
>> EF_MIPS_NAN2008 = 0x00000400, // Uses IEE 754-2008 NaN encoding<br>
>> +<br>
>> + // ABI flags<br>
>> EF_MIPS_ABI_O32 = 0x00001000, // This file follows the first MIPS 32<br>
>> bit ABI<br>
>> + EF_MIPS_ABI_O64 = 0x00002000, // O32 ABI extended for 64-bit<br>
>> architecture.<br>
>> + EF_MIPS_ABI_EABI32 = 0x00003000, // EABI in 32 bit mode.<br>
>> + EF_MIPS_ABI_EABI64 = 0x00004000, // EABI in 64 bit mode.<br>
>> + EF_MIPS_ABI = 0x0000f000, // Mask for selecting EF_MIPS_ABI_<br>
>> variant.<br>
>><br>
>> //ARCH_ASE<br>
>> EF_MIPS_MICROMIPS = 0x02000000, // microMIPS<br>
<br>
--<br>
Simon Atanasyan<o:p></o:p></p>
</div>
</div>
</div>
</body>
</html>