<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Oct 27, 2014, at 9:01 AM, Marshall Clow <<a href="mailto:mclow.lists@gmail.com">mclow.lists@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-size: 11px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">On Oct 27, 2014, at 8:16 AM, Ismail Pazarbasi <<a href="mailto:ismail.pazarbasi@gmail.com">ismail.pazarbasi@gmail.com</a>> wrote:<br><br><blockquote type="cite">On Sun, Oct 26, 2014 at 4:35 AM, Alexey Samsonov <<a href="mailto:vonosmas@gmail.com">vonosmas@gmail.com</a>> wrote:<br><blockquote type="cite">Author: samsonov<br>Date: Sat Oct 25 22:35:14 2014<br>New Revision: 220635<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=220635&view=rev">http://llvm.org/viewvc/llvm-project?rev=220635&view=rev</a><br>Log:<br>[Sanitizer] Make StackTrace a lightweight reference to array of PCs, and<br>introduce a BufferedStackTrace class, which owns this array.<br><br>Summary:<br>This change splits __sanitizer::StackTrace class into a lightweight<br>__sanitizer::StackTrace, which doesn't own array of PCs, and BufferedStackTrace,<br>which owns it. This would allow us to simplify the interface of StackDepot,<br>and eventually merge __sanitizer::StackTrace with __tsan::StackTrace.<br><br>Test Plan: regression test suite.<br><br>Reviewers: kcc, dvyukov<br><br>Reviewed By: dvyukov<br><br>Subscribers: llvm-commits<br><br>[snip]<br></blockquote><br>Hi Alexey,<br><br>I have found my Mac build was broken. How does the patch look?<br></blockquote><br>I, too, have noticed that the Mac build is broken.<br><br>[ 24%] /Sources/LLVM/llvm/projects/compiler-rt/lib/asan/asan_mac.cc:302:31: error: no matching function for call to 'asan_malloc'<br> (asan_block_context_t*) asan_malloc(sizeof(asan_block_context_t), stack);<br> ^~~~~~~~~~~<br>/Sources/LLVM/llvm/projects/compiler-rt/lib/asan/asan_allocator.h:148:7: note: candidate function not viable: cannot convert from base class pointer '__sanitizer::StackTrace *' to derived class pointer '__sanitizer::BufferedStackTrace *' for 2nd argument<br>void *asan_malloc(uptr size, BufferedStackTrace *stack);<br> ^<br>1 error generated.</div></blockquote><br></div><div>I can also confirm that Ismail’s patch fixes the compilation failure.</div><div>I have no idea if the patch is *correct*, but it now compiles.</div><div><br></div><div>— Marshall</div><div><br></div><br></body></html>