<div dir="ltr">Hi Alexey,<div><br></div><div>vectorize-loops and vectorize-slp are off by default (though now they can be turned on/off with this patch). Adding Nadav, I'm not the right person to decide whether they should be on by default or not.<br></div><div><br></div><div>JF</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 24, 2014 at 5:27 AM, Alexey Volkov <span dir="ltr"><<a href="mailto:avolkov.intel@gmail.com" target="_blank">avolkov.intel@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi JF,<div><br></div><div>After your commit I saw a performance regression because of disabled Loop Vectorizer:</div><div> LV: Not vectorizing: No #pragma vectorize enable.<br></div><div>It is really strange since I used -Ofast -flto clang's options to build an application.</div><div>Before this change loop was successfully vectorized by Loop Vectorizer.</div><div><br></div><div>Thanks, Alexey.</div></div><div class="gmail_extra"><div><div class="h5"><br><div class="gmail_quote">2014-10-22 3:18 GMT+04:00 JF Bastien <span dir="ltr"><<a href="mailto:jfb@google.com" target="_blank">jfb@google.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: jfb<br>
Date: Tue Oct 21 18:18:21 2014<br>
New Revision: 220345<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=220345&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=220345&view=rev</a><br>
Log:<br>
LTO: respect command-line options that disable vectorization.<br>
<br>
Summary: Patches 202051 and 208013 added calls to LTO's PassManager which unconditionally add LoopVectorizePass and SLPVectorizerPass instead of following the logic in PassManagerBuilder::populateModulePassManager and honoring the -vectorize-loops -run-slp-after-loop-vectorization flags.<br>
<br>
Reviewers: nadav, aschwaighofer, yijiang<br>
<br>
Subscribers: llvm-commits<br>
<br>
Differential Revision: <a href="http://reviews.llvm.org/D5884" target="_blank">http://reviews.llvm.org/D5884</a><br>
<br>
Modified:<br>
    llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp<br>
<br>
Modified: llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp?rev=220345&r1=220344&r2=220345&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp?rev=220345&r1=220344&r2=220345&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp Tue Oct 21 18:18:21 2014<br>
@@ -440,10 +440,12 @@ void PassManagerBuilder::addLTOOptimizat<br>
   // More loops are countable; try to optimize them.<br>
   PM.add(createIndVarSimplifyPass());<br>
   PM.add(createLoopDeletionPass());<br>
-  PM.add(createLoopVectorizePass(true, true));<br>
+  PM.add(createLoopVectorizePass(DisableUnrollLoops, LoopVectorize));<br>
<br>
   // More scalar chains could be vectorized due to more alias information<br>
-  PM.add(createSLPVectorizerPass()); // Vectorize parallel scalar chains.<br>
+  if (RunSLPAfterLoopVectorization)<br>
+    if (SLPVectorize)<br>
+      PM.add(createSLPVectorizerPass()); // Vectorize parallel scalar chains.<br>
<br>
   // After vectorization, assume intrinsics may tell us more about pointer<br>
   // alignments.<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div></div></div><span class="HOEnZb"><font color="#888888">-- <br><div dir="ltr">Alexey Volkov<div>Intel Corporation</div></div>
</font></span></div>
</blockquote></div><br></div>