<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">See my other mail.<div class=""><br class=""></div><div class=""><div><blockquote type="cite" class=""><div class="">On Oct 24, 2014, at 8:53 AM, JF Bastien <<a href="mailto:jfb@google.com" class="">jfb@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Hi Alexey,<div class=""><br class=""></div><div class="">vectorize-loops and vectorize-slp are off by default (though now they can be turned on/off with this patch). Adding Nadav, I'm not the right person to decide whether they should be on by default or not.<br class=""></div><div class=""><br class=""></div><div class="">JF</div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Fri, Oct 24, 2014 at 5:27 AM, Alexey Volkov <span dir="ltr" class=""><<a href="mailto:avolkov.intel@gmail.com" target="_blank" class="">avolkov.intel@gmail.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="">Hi JF,<div class=""><br class=""></div><div class="">After your commit I saw a performance regression because of disabled Loop Vectorizer:</div><div class=""> LV: Not vectorizing: No #pragma vectorize enable.<br class=""></div><div class="">It is really strange since I used -Ofast -flto clang's options to build an application.</div><div class="">Before this change loop was successfully vectorized by Loop Vectorizer.</div><div class=""><br class=""></div><div class="">Thanks, Alexey.</div></div><div class="gmail_extra"><div class=""><div class="h5"><br class=""><div class="gmail_quote">2014-10-22 3:18 GMT+04:00 JF Bastien <span dir="ltr" class=""><<a href="mailto:jfb@google.com" target="_blank" class="">jfb@google.com</a>></span>:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: jfb<br class="">
Date: Tue Oct 21 18:18:21 2014<br class="">
New Revision: 220345<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=220345&view=rev" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=220345&view=rev</a><br class="">
Log:<br class="">
LTO: respect command-line options that disable vectorization.<br class="">
<br class="">
Summary: Patches 202051 and 208013 added calls to LTO's PassManager which unconditionally add LoopVectorizePass and SLPVectorizerPass instead of following the logic in PassManagerBuilder::populateModulePassManager and honoring the -vectorize-loops -run-slp-after-loop-vectorization flags.<br class="">
<br class="">
Reviewers: nadav, aschwaighofer, yijiang<br class="">
<br class="">
Subscribers: llvm-commits<br class="">
<br class="">
Differential Revision: <a href="http://reviews.llvm.org/D5884" target="_blank" class="">http://reviews.llvm.org/D5884</a><br class="">
<br class="">
Modified:<br class="">
llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp<br class="">
<br class="">
Modified: llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp?rev=220345&r1=220344&r2=220345&view=diff" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp?rev=220345&r1=220344&r2=220345&view=diff</a><br class="">
==============================================================================<br class="">
--- llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp (original)<br class="">
+++ llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp Tue Oct 21 18:18:21 2014<br class="">
@@ -440,10 +440,12 @@ void PassManagerBuilder::addLTOOptimizat<br class="">
// More loops are countable; try to optimize them.<br class="">
PM.add(createIndVarSimplifyPass());<br class="">
PM.add(createLoopDeletionPass());<br class="">
- PM.add(createLoopVectorizePass(true, true));<br class="">
+ PM.add(createLoopVectorizePass(DisableUnrollLoops, LoopVectorize));<br class="">
<br class="">
// More scalar chains could be vectorized due to more alias information<br class="">
- PM.add(createSLPVectorizerPass()); // Vectorize parallel scalar chains.<br class="">
+ if (RunSLPAfterLoopVectorization)<br class="">
+ if (SLPVectorize)<br class="">
+ PM.add(createSLPVectorizerPass()); // Vectorize parallel scalar chains.<br class="">
<br class="">
// After vectorization, assume intrinsics may tell us more about pointer<br class="">
// alignments.<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank" class="">llvm-commits@cs.uiuc.edu</a><br class="">
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank" class="">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div><br class=""><br clear="all" class=""><div class=""><br class=""></div></div></div><span class="HOEnZb"><font color="#888888" class="">-- <br class=""><div dir="ltr" class="">Alexey Volkov<div class="">Intel Corporation</div></div>
</font></span></div>
</blockquote></div><br class=""></div>
_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@cs.uiuc.edu" class="">llvm-commits@cs.uiuc.edu</a><br class="">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br class=""></div></blockquote></div><br class=""></div></body></html>