Do you mean checking if we're using gcc and adding -Wno-comment if so?<div><br></div><div>I'm okay with that option too. I'd like it if llvm/clang's build didn't have any warnings by default on supported platforms (if possible). I figured since it's a test, the C-style comments wouldn't be a big problem, but it seems I was wrong ;-)</div><div><br></div><div>Chandler: is that solution acceptable, or would you prefer it if I left it as it was before and just worked around on our Linux boxes?</div><div><br></div><div>Thanks,</div><div><br></div><div> Filipe</div><div><br></div><div>P.S: I should only be able to revert it or change it tomorrow morning. If that's not ok, please revert it.<span></span><br><br>On Wednesday, October 22, 2014, dblaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Oct 21, 2014 at 7:16 PM, Filipe Cabecinhas <span dir="ltr"><<a href="javascript:_e(%7B%7D,'cvml','me@filcab.net');" target="_blank">me@filcab.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: filcab<br>
Date: Tue Oct 21 21:16:06 2014<br>
New Revision: 220360<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=220360&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=220360&view=rev</a><br>
Log:<br>
Silence gcc's -Wcomment<br>
<br>
gcc's (4.7, I think) -Wcomment warning is not "as smart" as clang's and<br>
warns even if the line right after the backslash-newline sequence only has<br>
a line comment that starts at the beginning of the line.<br></blockquote><div><br></div><div>Could we just disable GCC's warning in the LLVM build system?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
llvm/trunk/unittests/Analysis/LazyCallGraphTest.cpp<br>
<br>
Modified: llvm/trunk/unittests/Analysis/LazyCallGraphTest.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/Analysis/LazyCallGraphTest.cpp?rev=220360&r1=220359&r2=220360&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/Analysis/LazyCallGraphTest.cpp?rev=220360&r1=220359&r2=220360&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/unittests/Analysis/LazyCallGraphTest.cpp (original)<br>
+++ llvm/trunk/unittests/Analysis/LazyCallGraphTest.cpp Tue Oct 21 21:16:06 2014<br>
@@ -37,21 +37,23 @@ std::unique_ptr<Module> parseAssembly(co<br>
return M;<br>
}<br>
<br>
-// IR forming a call graph with a diamond of triangle-shaped SCCs:<br>
-//<br>
-// d1<br>
-// / \<br>
-// d3--d2<br>
-// / \<br>
-// b1 c1<br>
-// / \ / \<br>
-// b3--b2 c3--c2<br>
-// \ /<br>
-// a1<br>
-// / \<br>
-// a3--a2<br>
-//<br>
-// All call edges go up between SCCs, and clockwise around the SCC.<br>
+/*<br>
+ IR forming a call graph with a diamond of triangle-shaped SCCs:<br>
+<br>
+ d1<br>
+ / \<br>
+ d3--d2<br>
+ / \<br>
+ b1 c1<br>
+ / \ / \<br>
+ b3--b2 c3--c2<br>
+ \ /<br>
+ a1<br>
+ / \<br>
+ a3--a2<br>
+<br>
+ All call edges go up between SCCs, and clockwise around the SCC.<br>
+ */<br>
static const char DiamondOfTriangles[] =<br>
"define void @a1() {\n"<br>
"entry:\n"<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="javascript:_e(%7B%7D,'cvml','llvm-commits@cs.uiuc.edu');" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>
</blockquote></div>