<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Oct 20, 2014 at 1:32 PM, Alexey Samsonov <span dir="ltr"><<a href="mailto:vonosmas@gmail.com" target="_blank">vonosmas@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: samsonov<br>
Date: Mon Oct 20 15:32:47 2014<br>
New Revision: 220231<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=220231&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=220231&view=rev</a><br>
Log:<br>
Add const version of OwningBinary::getBinary<br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/Object/Binary.h<br>
<br>
Modified: llvm/trunk/include/llvm/Object/Binary.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Object/Binary.h?rev=220231&r1=220230&r2=220231&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Object/Binary.h?rev=220231&r1=220230&r2=220231&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/Object/Binary.h (original)<br>
+++ llvm/trunk/include/llvm/Object/Binary.h Mon Oct 20 15:32:47 2014<br>
@@ -140,6 +140,7 @@ public:<br>
   OwningBinary<T> &operator=(OwningBinary<T> &&Other);<br>
<br>
   std::unique_ptr<T> &getBinary();<br>
+  const std::unique_ptr<T> &getBinary() const;<br>
   std::unique_ptr<MemoryBuffer> &getBuffer();<br>
 };<br>
<br>
@@ -165,6 +166,11 @@ template <typename T> std::unique_ptr<T><br>
   return Bin;<br>
 }<br>
<br>
+template <typename T><br>
+const std::unique_ptr<T> &OwningBinary<T>::getBinary() const {<br></blockquote><div><br></div><div>Slightly curious thing to have a const version of, though it's probably the best thing for symmetry (since ownership can't be transferred, it could just return T* or, if it's always non-null, a T& - but it'd be weirdly asymmetric). What's it for?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+  return Bin;<br>
+}<br>
+<br>
 template <typename T><br>
 std::unique_ptr<MemoryBuffer> &OwningBinary<T>::getBuffer() {<br>
   return Buf;<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>