<div dir="ltr"><div><div>Thanks for the hint! I wasn't sure what to do there because this seemed a bit weird:<br>   if (const OverflowingBinaryOperator *OBO = dyn_cast<OverflowingBinaryOperator>(V)) {<br>
<br></div>We're not specifying 'const' in the dyn_cast itself in the first two instances...although in the last case we did:<br>   else if (const FPMathOperator *FPMO = dyn_cast<const FPMathOperator>(V)) {<br><br></div>Should I add the 2nd 'const' inside the dyn_cast< > for all cases as well as on the 'auto'?<br><div><div>
<br></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 15, 2014 at 10:47 AM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I /think/ we generally like to still specify the 'const' when using auto (like we specify the '*') - though this probably isn't a hard-and-fast rule, just a thought.</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 15, 2014 at 9:21 AM, Sanjay Patel <span dir="ltr"><<a href="mailto:spatel@rotateright.com" target="_blank">spatel@rotateright.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: spatel<br>
Date: Wed Oct 15 11:21:37 2014<br>
New Revision: 219804<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=219804&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=219804&view=rev</a><br>
Log:<br>
Use 'auto' for easier reading; no functional change intended.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Bitcode/Writer/BitcodeWriter.cpp<br>
<br>
Modified: llvm/trunk/lib/Bitcode/Writer/BitcodeWriter.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Bitcode/Writer/BitcodeWriter.cpp?rev=219804&r1=219803&r2=219804&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Bitcode/Writer/BitcodeWriter.cpp?rev=219804&r1=219803&r2=219804&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Bitcode/Writer/BitcodeWriter.cpp (original)<br>
+++ llvm/trunk/lib/Bitcode/Writer/BitcodeWriter.cpp Wed Oct 15 11:21:37 2014<br>
@@ -710,18 +710,15 @@ static void WriteModuleInfo(const Module<br>
 static uint64_t GetOptimizationFlags(const Value *V) {<br>
   uint64_t Flags = 0;<br>
<br>
-  if (const OverflowingBinaryOperator *OBO =<br>
-        dyn_cast<OverflowingBinaryOperator>(V)) {<br>
+  if (auto *OBO = dyn_cast<OverflowingBinaryOperator>(V)) {<br>
     if (OBO->hasNoSignedWrap())<br>
       Flags |= 1 << bitc::OBO_NO_SIGNED_WRAP;<br>
     if (OBO->hasNoUnsignedWrap())<br>
       Flags |= 1 << bitc::OBO_NO_UNSIGNED_WRAP;<br>
-  } else if (const PossiblyExactOperator *PEO =<br>
-               dyn_cast<PossiblyExactOperator>(V)) {<br>
+  } else if (auto *PEO = dyn_cast<PossiblyExactOperator>(V)) {<br>
     if (PEO->isExact())<br>
       Flags |= 1 << bitc::PEO_EXACT;<br>
-  } else if (const FPMathOperator *FPMO =<br>
-             dyn_cast<const FPMathOperator>(V)) {<br>
+  } else if (auto *FPMO = dyn_cast<const FPMathOperator>(V)) {<br>
     if (FPMO->hasUnsafeAlgebra())<br>
       Flags |= FastMathFlags::UnsafeAlgebra;<br>
     if (FPMO->hasNoNaNs())<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>