<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Oct 12, 2014 at 8:36 AM, Benjamin Kramer <span dir="ltr"><<a href="mailto:benny.kra@googlemail.com" target="_blank">benny.kra@googlemail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: d0k<br>
Date: Sun Oct 12 10:36:31 2014<br>
New Revision: 219586<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=219586&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=219586&view=rev</a><br>
Log:<br>
APSInt: Simplify code to reduce the number of copies. No functionality change.<br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/ADT/APSInt.h<br>
<br>
Modified: llvm/trunk/include/llvm/ADT/APSInt.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/APSInt.h?rev=219586&r1=219585&r2=219586&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/APSInt.h?rev=219586&r1=219585&r2=219586&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/ADT/APSInt.h (original)<br>
+++ llvm/trunk/include/llvm/ADT/APSInt.h Sun Oct 12 10:36:31 2014<br>
@@ -269,19 +269,15 @@ public:<br>
     else if (I2.getBitWidth() > I1.getBitWidth())<br>
       return isSameValue(I1.extend(I2.getBitWidth()), I2);<br>
<br>
-    // We have a signedness mismatch. Turn the signed value into an unsigned<br>
-    // value.<br>
-    if (I1.isSigned()) {<br>
-      if (I1.isNegative())<br>
-        return false;<br>
+    assert(I1.isSigned() != I2.isSigned());<br>
<br>
-      return APSInt(I1, true) == I2;<br>
-    }<br>
-<br>
-    if (I2.isNegative())<br>
+    // We have a signedness mismatch. Check for negative values and do an<br>
+    // unsigned compare if signs match.<br>
+    if ((I1.isSigned() && I1.isNegative()) ||<br>
+        (!I1.isSigned() && I2.isNegative()))<br>
       return false;<br>
<br>
-    return I1 == APSInt(I2, true);<br>
+    return I1.eq(I2);<br></blockquote><div><br></div><div>Hmm, is this different from l1 == l2? (that seems like a dangerously subtle API if that's the case)</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
   }<br>
<br>
   /// Profile - Used to insert APSInt objects, or objects that contain APSInt<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>