<div dir="ltr">Thanks for doing this Hal.</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Oct 9, 2014 at 8:56 PM, Hal Finkel <span dir="ltr"><<a href="mailto:hfinkel@anl.gov" target="_blank">hfinkel@anl.gov</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: hfinkel<br>
Date: Thu Oct  9 22:56:24 2014<br>
New Revision: 219469<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=219469&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=219469&view=rev</a><br>
Log:<br>
[LVI] Revert the remainder of "r218231 - Add two thresholds lvi-overdefined-BB-threshold and lvi-overdefined-threshold"<br>
<br>
Some of r218231 was reverted with the code that used it in r218971, but not all<br>
of it. This removes the rest (which is now dead).<br>
<br>
Modified:<br>
    llvm/trunk/lib/Analysis/LazyValueInfo.cpp<br>
<br>
Modified: llvm/trunk/lib/Analysis/LazyValueInfo.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/LazyValueInfo.cpp?rev=219469&r1=219468&r2=219469&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/LazyValueInfo.cpp?rev=219469&r1=219468&r2=219469&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Analysis/LazyValueInfo.cpp (original)<br>
+++ llvm/trunk/lib/Analysis/LazyValueInfo.cpp Thu Oct  9 22:56:24 2014<br>
@@ -27,7 +27,6 @@<br>
 #include "llvm/IR/IntrinsicInst.h"<br>
 #include "llvm/IR/PatternMatch.h"<br>
 #include "llvm/IR/ValueHandle.h"<br>
-#include "llvm/Support/CommandLine.h"<br>
 #include "llvm/Support/Debug.h"<br>
 #include "llvm/Support/raw_ostream.h"<br>
 #include "llvm/Target/TargetLibraryInfo.h"<br>
@@ -38,20 +37,6 @@ using namespace PatternMatch;<br>
<br>
 #define DEBUG_TYPE "lazy-value-info"<br>
<br>
-// Experimentally derived threshold for the number of basic blocks lowered for<br>
-// lattice value overdefined.<br>
-static cl::opt<unsigned><br>
-OverdefinedBBThreshold("lvi-overdefined-BB-threshold",<br>
-    cl::init(1500), cl::Hidden,<br>
-    cl::desc("Threshold of the number of basic blocks lowered for lattice value"<br>
-             "'overdefined'."));<br>
-<br>
-// Experimentally derived threshold for additional lowering lattice values<br>
-// overdefined per block.<br>
-static cl::opt<unsigned><br>
-OverdefinedThreshold("lvi-overdefined-threshold", cl::init(10), cl::Hidden,<br>
-    cl::desc("Threshold of lowering lattice value 'overdefined'."));<br>
-<br>
 char LazyValueInfo::ID = 0;<br>
 INITIALIZE_PASS_BEGIN(LazyValueInfo, "lazy-value-info",<br>
                 "Lazy Value Information Analysis", false, true)<br>
@@ -363,9 +348,6 @@ namespace {<br>
     const DataLayout *DL;<br>
     /// An optional DT pointer.<br>
     DominatorTree *DT;<br>
-    /// A counter to record how many times Overdefined has been tried to be<br>
-    /// lowered.<br>
-    DenseMap<BasicBlock *, unsigned> LoweringOverdefinedTimes;<br>
<br>
     friend struct LVIValueHandle;<br>
<br>
@@ -498,9 +480,6 @@ void LazyValueInfoCache::eraseBlock(Basi<br>
 }<br>
<br>
 void LazyValueInfoCache::solve() {<br>
-  // Reset the counter of lowering overdefined value.<br>
-  LoweringOverdefinedTimes.clear();<br>
-<br>
   while (!BlockValueStack.empty()) {<br>
     std::pair<BasicBlock*, Value*> &e = BlockValueStack.top();<br>
     if (solveBlockValue(e.second, e.first)) {<br>
@@ -559,7 +538,6 @@ bool LazyValueInfoCache::solveBlockValue<br>
   // lattice value to overdefined, so that cycles will terminate and be<br>
   // conservatively correct.<br>
   BBLV.markOverdefined();<br>
-  ++LoweringOverdefinedTimes[BB];<br>
<br>
   Instruction *BBI = dyn_cast<Instruction>(Val);<br>
   if (!BBI || BBI->getParent() != BB) {<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>