<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 12 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal">Hi –<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I recently was trying to add switch which used a custom parser by following the directions at
<a href="http://llvm.org/docs/CommandLine.html#custom-parser">http://llvm.org/docs/CommandLine.html#custom-parser</a>. However, the example is out-of-date, and I wanted to fix it so that others using it in the future will not get confused. This is an issue
that has been around for quite a while as I found an email regarding it was sent out in January of 2012 (http://lists.cs.uiuc.edu/pipermail/llvmdev/2012-January/046919.html), but it was never fixed. My changes allow it to work with the latest version of trunk
that I tested, revision 219325.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Files:<o:p></o:p></p>
<p class="MsoNormal"> Docs/CommandLine.rst<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="font-family:Consolas">======8<======<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">Index: docs/CommandLine.rst<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">===================================================================<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">--- docs/CommandLine.rst (revision 219288)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">+++ docs/CommandLine.rst (working copy)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">@@ -1630,13 +1630,13 @@<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">.. code-block:: c++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">- struct FileSizeParser : public cl::basic_parser<unsigned> {<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">+ struct FileSizeParser : public cl::parser<unsigned> {<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas"> // parse - Return true on error.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">- bool parse(cl::Option &O, const char *ArgName, const std::string &ArgValue,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">+ bool parse(cl::Option &O, StringRef ArgName, const std::string &ArgValue,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas"> unsigned &Val);<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas"> };<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">-Our new class inherits from the ``cl::basic_parser`` template class to fill in<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">+Our new class inherits from the ``cl::parser`` template class to fill in<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">the default, boiler plate code for us. We give it the data type that we parse<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">into, the last argument to the ``parse`` method, so that clients of our custom<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">parser know what object type to pass in to the parse method. (Here we declare<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">@@ -1652,7 +1652,7 @@<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">.. code-block:: c++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">- bool FileSizeParser::parse(cl::Option &O, const char *ArgName,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">+ bool FileSizeParser::parse(cl::Option &O, StringRef ArgName,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas"> const std::string &Arg, unsigned &Val) {<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas"> const char *ArgStart = Arg.c_str();<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas"> char *End;<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">@@ -1698,7 +1698,7 @@<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas"> OPTIONS:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas"> -help - display available options (-help-hidden for more)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas"> ...<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">- -max-file-size=<size> - Maximum file size to accept<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">+ -max-file-size=<size> - Maximum file size to accept<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">And we can test that our parse works correctly now (the test program just prints<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">out the max-file-size argument value):<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">======8<======<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>