<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 8, 2014 at 5:41 AM, Alexander Potapenko <span dir="ltr"><<a href="mailto:glider@google.com" target="_blank">glider@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: glider<br>
Date: Wed Oct  8 07:41:11 2014<br>
New Revision: 219302<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=219302&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=219302&view=rev</a><br>
Log:<br>
[ASan] Bump the minimum OSX version required to run ASan to 10.7.<br>
<br>
<br>
Modified:<br>
    compiler-rt/trunk/CMakeLists.txt<br>
    compiler-rt/trunk/make/platform/<a href="http://clang_darwin.mk" target="_blank">clang_darwin.mk</a><br>
<br>
Modified: compiler-rt/trunk/CMakeLists.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/CMakeLists.txt?rev=219302&r1=219301&r2=219302&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/CMakeLists.txt?rev=219302&r1=219301&r2=219302&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/CMakeLists.txt (original)<br>
+++ compiler-rt/trunk/CMakeLists.txt Wed Oct  8 07:41:11 2014<br>
@@ -299,7 +299,7 @@ if(APPLE)<br>
   if(COMPILER_RT_USES_LIBCXX)<br>
     set(SANITIZER_MIN_OSX_VERSION 10.7)<br>
   else()<br>
-    set(SANITIZER_MIN_OSX_VERSION 10.6)<br>
+    set(SANITIZER_MIN_OSX_VERSION 10.7)<br></blockquote><div><br></div><div>You can get rid of the if-else now. Note that it's the only place where COMPILER_RT_USES_LIBCXX is used, so</div><div>now you may kill this variable as well.</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
   endif()<br>
   set(CMAKE_OSX_DEPLOYMENT_TARGET "") # We're setting the flag manually below.<br>
   set(DARWIN_osx_CFLAGS -mmacosx-version-min=${SANITIZER_MIN_OSX_VERSION})<br>
<br>
Modified: compiler-rt/trunk/make/platform/<a href="http://clang_darwin.mk" target="_blank">clang_darwin.mk</a><br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/make/platform/clang_darwin.mk?rev=219302&r1=219301&r2=219302&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/make/platform/clang_darwin.mk?rev=219302&r1=219301&r2=219302&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/make/platform/<a href="http://clang_darwin.mk" target="_blank">clang_darwin.mk</a> (original)<br>
+++ compiler-rt/trunk/make/platform/<a href="http://clang_darwin.mk" target="_blank">clang_darwin.mk</a> Wed Oct  8 07:41:11 2014<br>
@@ -157,7 +157,7 @@ CFLAGS.eprintf              := $(CFLAGS) $(OSX_DEPLO<br>
 CFLAGS.10.4            := $(CFLAGS) $(OSX_DEPLOYMENT_ARGS)<br>
 # FIXME: We can't build ASAN with our stub SDK yet.<br>
 CFLAGS.asan_osx_dynamic := \<br>
-       $(CFLAGS) -mmacosx-version-min=10.6 -fno-builtin \<br>
+       $(CFLAGS) -mmacosx-version-min=10.7 -fno-builtin \<br>
        -gline-tables-only \<br>
        -DMAC_INTERPOSE_FUNCTIONS=1<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">Alexey Samsonov<br><a href="mailto:vonosmas@gmail.com" target="_blank">vonosmas@gmail.com</a></div>
</div></div>