<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Oct 7, 2014, at 2:30 PM, Eric Christopher <<a href="mailto:echristo@gmail.com" class="">echristo@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">On Tue, Oct 7, 2014 at 2:00 PM, Frédéric Riss <</span><a href="mailto:friss@apple.com" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">friss@apple.com</a><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">> wrote:</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br class="">On Oct 7, 2014, at 1:26 PM, Eric Christopher <<a href="mailto:echristo@gmail.com" class="">echristo@gmail.com</a>> wrote:<br class=""><br class="">On Tue, Oct 7, 2014 at 12:57 PM, Frederic Riss <<a href="mailto:friss@apple.com" class="">friss@apple.com</a>> wrote:<br class=""><br class="">================<br class="">Comment at: include/llvm/Support/Dwarf.h:784<br class="">@@ -783,1 +783,3 @@<br class="">+/// Contstants for the DW_APPLE_PROPERTY_attributes attribute.<br class="">+/// Keep this list in sync with clang's DeclSpec.h<br class="">ObjCPropertyAttributeKind.<br class="">enum ApplePropertyAttributes {<br class="">----------------<br class="">dblaikie wrote:<br class=""><br class="">Crazy idea: Could we do this the other way around, and remove<br class="">ObjCPropertyAttributeKind in favor of using this enum directly?<br class=""><br class="">Probably not, but figured I'd mention it.<br class=""><br class="">I thought of that but I think there would be (rightful) resistance to having<br class="">Sema code depend on the Dwarf header. In a followup patch for the dwarfdump<br class="">functionality, I'll try to add coverage for most if not all of these, that<br class="">will at least prevent us from breaking the current values unknowingly.<br class=""><br class=""><br class="">So it's not so much resistance to having Sema code depend on the dwarf<br class="">header... if we'd write the same code both ways. This code looks a bit<br class="">weird that way in that having the header wouldn't necessarily change<br class="">things.<br class=""><br class=""><br class="">Not sure I’m getting what you’re implying. I could have included Dwarf.h in<br class="">DeclSpec.h and define the enum values of the ObjCPropertyAttributeKind in<br class="">terms of the Dwarf.h values, or even more radically remove<br class="">ObjCPropertyAttributeKind and rewrite all the code using these enums to use<br class="">DW_APPLE_PROPERTY_* values instead.<br class=""><br class=""></blockquote><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Right, the problem is that it is a pretty bad hack either way. Or at</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">least seems so to me. Can run the code by Richard though if you'd like</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">to try.</span><br class=""></div></blockquote><br class=""></div><div>No, I think the current patch with the upcoming test coverage is better. I was just mentioning to Dave that I had the same thoughts while writing the patch, but it would look too weird IMHO. </div><div><br class=""></div><div>Fred</div><br class=""></body></html>