<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Oct 7, 2014 at 2:15 PM, Kaelyn Takata <span dir="ltr"><<a href="mailto:rikka@google.com" target="_blank">rikka@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rikka<br>
Date: Tue Oct  7 16:15:51 2014<br>
New Revision: 219240<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=219240&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=219240&view=rev</a><br>
Log:<br>
Add size_t MapVector::erase(KeyT) similar to the one in std::map.<br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/ADT/MapVector.h<br>
    llvm/trunk/unittests/ADT/MapVectorTest.cpp<br>
<br>
Modified: llvm/trunk/include/llvm/ADT/MapVector.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/MapVector.h?rev=219240&r1=219239&r2=219240&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/MapVector.h?rev=219240&r1=219239&r2=219240&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/ADT/MapVector.h (original)<br>
+++ llvm/trunk/include/llvm/ADT/MapVector.h Tue Oct  7 16:15:51 2014<br>
@@ -147,6 +147,17 @@ public:<br>
     return Next;<br>
   }<br>
<br>
+  /// \brief Remove all elements with the key value Key.<br>
+  ///<br>
+  /// Returns the number of elements removed.<br>
+  size_type erase(const KeyT &Key) {<br>
+    auto Iterator = find(Key);<br>
+    if (Iterator == end())<br>
+      return 0;<br>
+    erase(Iterator);<br>
+    return 1;<br>
+  }<br>
+<br>
   /// \brief Remove the elements that match the predicate.<br>
   ///<br>
   /// Erase all elements that match \c Pred in a single pass.  Takes linear<br>
<br>
Modified: llvm/trunk/unittests/ADT/MapVectorTest.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ADT/MapVectorTest.cpp?rev=219240&r1=219239&r2=219240&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ADT/MapVectorTest.cpp?rev=219240&r1=219239&r2=219240&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/unittests/ADT/MapVectorTest.cpp (original)<br>
+++ llvm/trunk/unittests/ADT/MapVectorTest.cpp Tue Oct  7 16:15:51 2014<br>
@@ -67,6 +67,11 @@ TEST(MapVectorTest, erase) {<br>
   ASSERT_EQ(MV.find(1), MV.end());<br>
   ASSERT_EQ(MV[3], 4);<br>
   ASSERT_EQ(MV[5], 6);<br>
+<br>
+  MV.erase(3);<br>
+  ASSERT_EQ(MV.size(), 1u);<br>
+  ASSERT_EQ(MV.find(3), MV.end());<br>
+  ASSERT_EQ(MV[5], 6);<br></blockquote><div><br></div><div>Maybe a test for the return value? And a negative test (when the element isn't in the container)</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
 }<br>
<br>
 TEST(MapVectorTest, remove_if) {<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>