<div dir="ltr">LGTM. I feel like we might want to be doing something more systematic to ensure that identical sub-expressions are correctly modeled throughout the reassociate pass, but this seems like an obvious strict improvement. =]</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Oct 2, 2014 at 9:15 AM, Dmitri Shtilman <span dir="ltr"><<a href="mailto:dshtilman@icloud.com" target="_blank">dshtilman@icloud.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Please review.<br>
<span class="im HOEnZb"><br>
On Sep 24, 2014, at 3:49 PM, Dmitri Shtilman <<a href="mailto:dshtilman@icloud.com">dshtilman@icloud.com</a>> wrote:<br>
<br>
</span><div class="HOEnZb"><div class="h5">> Hi all,<br>
><br>
> The following small patch gives the Reassociate pass a bit more flexibility and autonomy when optimizing expressions.<br>
> Particularly, it addresses cases where Reassociate breaks Subtracts but then fails to optimize combinations like I1 + -I2 where I1 and I2 have the same rank and are identical.<br>
><br>
> Please review.<br>
> Dmitri<br>
><br>
</div></div><div class="HOEnZb"><div class="h5">> <Reassociate.patch>_______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>