<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Oct 4, 2014, at 3:27 AM, İsmail Dönmez <<a href="mailto:ismail@donmez.ws" class="">ismail@donmez.ws</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Hi,<div class="gmail_extra"><br class=""><div class="gmail_quote">On Sat, Oct 4, 2014 at 3:18 AM, Steven Wu <span dir="ltr" class=""><<a href="mailto:stevenwu@apple.com" target="_blank" class="">stevenwu@apple.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: steven_wu<br class="">
Date: Fri Oct 3 19:18:59 2014<br class="">
New Revision: 219040<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=219040&view=rev" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=219040&view=rev</a><br class="">
Log:<br class="">
Fix the armv7 thumb builtins on darwin<br class="">
<br class="">
The arm builtins converted into thumb in r213481 are not working<br class="">
on darwin. On apple platforms, .thumb_func directive is required<br class="">
to generated correct symbols for thumb functions.<br class="">
<br class="">
<<a href="rdar://problem/18523605" class="">rdar://problem/18523605</a>><br class=""></blockquote><div class=""><br class=""></div><div class="">This breaks compilation on ARM/Linux:</div><div class=""><br class=""></div><div class=""><div class="">../projects/compiler-rt/lib/builtins/arm/sync_fetch_and_add_4.S:20:92: error: unexpected token in argument list</div><div class="">.p2align 2 ; .thumb ; .syntax unified ; ; .globl __sync_fetch_and_add_4 ; THUMB_FUNC .type __sync_fetch_and_add_4,%function ; __sync_fetch_and_add_4: dmb ; mov r12, r0 ; .L_tryatomic_add_4: ldrex r0, [r12] ; add r2, r0, r1 ; strex r3, r2, [r12] ; cmp r3, #0 ; bne .L_tryatomic_add_4 ; dmb ; bx lr</div></div><div class=""><br class=""></div><div class=""><div class="">../projects/compiler-rt/lib/builtins/arm/sync_fetch_and_add_8.S:22:92: error: unexpected token in argument list</div><div class="">.p2align 2 ; .thumb ; .syntax unified ; ; .globl __sync_fetch_and_add_8 ; THUMB_FUNC .type __sync_fetch_and_add_8,%function ; __sync_fetch_and_add_8: push {r4, r5, r6, lr} ; dmb ; mov r12, r0 ; .L_tryatomic_add_8: ldrexd r0, r1, [r12] ; adds r4, r0, r2 ; adc r5, r1, r3 ; strexd r6, r4, r5, [r12] ; cmp r6, #0 ; bne .L_tryatomic_add_8 ; dmb ; pop {r4, r5, r6, pc}</div></div></div></div></div></div></blockquote><br class=""></div><div>r219064 should fix it.</div><div><br class=""></div><div>(Steven, I also removed the reference to the Radar number. I don’t remember seeing that in the patch I originally reviewed. It is helpful Radar and bugzilla numbers in commit messages, but please don’t put them in comments in the code.)</div></body></html>