<p dir="ltr">Clang-tidy check for non-explicit operator bool?</p>
<p dir="ltr">Clang warning for implicit calls to operator bool?</p>
<div class="gmail_quote">On Oct 4, 2014 3:59 PM, "Benjamin Kramer" <<a href="mailto:benny.kra@googlemail.com">benny.kra@googlemail.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: d0k<br>
Date: Sat Oct  4 17:44:35 2014<br>
New Revision: 219069<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=219069&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=219069&view=rev</a><br>
Log:<br>
[SystemZ] Make operator bool explicit. NFC.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Target/SystemZ/SystemZElimCompare.cpp<br>
    llvm/trunk/lib/Target/SystemZ/SystemZInstrInfo.cpp<br>
<br>
Modified: llvm/trunk/lib/Target/SystemZ/SystemZElimCompare.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/SystemZ/SystemZElimCompare.cpp?rev=219069&r1=219068&r2=219069&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/SystemZ/SystemZElimCompare.cpp?rev=219069&r1=219068&r2=219069&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/SystemZ/SystemZElimCompare.cpp (original)<br>
+++ llvm/trunk/lib/Target/SystemZ/SystemZElimCompare.cpp Sat Oct  4 17:44:35 2014<br>
@@ -47,7 +47,7 @@ struct Reference {<br>
     return *this;<br>
   }<br>
<br>
-  operator bool() const { return Def || Use; }<br>
+  LLVM_EXPLICIT operator bool() const { return Def || Use; }<br>
<br>
   // True if the register is defined or used in some form, either directly or<br>
   // via a sub- or super-register.<br>
<br>
Modified: llvm/trunk/lib/Target/SystemZ/SystemZInstrInfo.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/SystemZ/SystemZInstrInfo.cpp?rev=219069&r1=219068&r2=219069&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/SystemZ/SystemZInstrInfo.cpp?rev=219069&r1=219068&r2=219069&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/SystemZ/SystemZInstrInfo.cpp (original)<br>
+++ llvm/trunk/lib/Target/SystemZ/SystemZInstrInfo.cpp Sat Oct  4 17:44:35 2014<br>
@@ -633,7 +633,7 @@ struct LogicOp {<br>
   LogicOp(unsigned regSize, unsigned immLSB, unsigned immSize)<br>
     : RegSize(regSize), ImmLSB(immLSB), ImmSize(immSize) {}<br>
<br>
-  operator bool() const { return RegSize; }<br>
+  LLVM_EXPLICIT operator bool() const { return RegSize; }<br>
<br>
   unsigned RegSize, ImmLSB, ImmSize;<br>
 };<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>