<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Oct 3, 2014, at 4:06 PM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><br class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Fri, Oct 3, 2014 at 3:58 PM, Frederic Riss <span dir="ltr" class=""><<a href="mailto:friss@apple.com" target="_blank" class="">friss@apple.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">================<br class="">
Comment at: test/DebugInfo/Inputs/gmlt.ll:46<br class="">
@@ -45,3 +45,3 @@<br class="">
<br class="">
-; CHECK: [[F3_ABS_DEF:.*]]: DW_TAG_subprogram<br class="">
+; CHECK: DW_TAG_subprogram<br class="">
; CHECK-NEXT: DW_AT_name {{.*}} "f3"<br class="">
----------------<br class="">
</span><span class="">dblaikie wrote:<br class="">
> Not sure - might even be worth dropping these abstract subprograms entirely when they're not checking anything interesting (just the name is being checked by the abstract_definition check you modified below). *shrug* dunno.<br class="">
</span>Unfortunately, in some test cases they have to stay because they 'consume' a part of the file. If I had removed this one, then the next TAG_subprogram would match the abstract DIE and the test would fail. This is one of the biggest shortcomings of testing the Dwarf contents with FileCheck IMHO.<br class=""></blockquote><div class=""><br class=""></div><div class="">Agreed - usually the way I do this is just to skip over the unintersting tags as quickly as possible (you'll see a few test cases that just hawe "CHECK: DW_TAG_subprogram" three times in a row, etc). Open to ideas on the best way to do that. Perhaps they sometimes merit comments, or not, perhaps sometimes they could just be a "CHECK: DW_TAG" to even more opaquely skip over uninteresting tags.</div></div></div></div></div></blockquote><div><br class=""></div><div>At some point it might make sense to either make llvm-dwardump also emit a syntax that is more amenable to FileCheck (one TAG per line), or the other way round.</div><div><br class=""></div><div>-- adrian</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><div class=""> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class=""><br class="">
================<br class="">
Comment at: test/DebugInfo/X86/inline-member-function.ll:24<br class="">
@@ +23,3 @@<br class="">
+; CHECK: DW_AT_specification {{.*}} "_ZN3foo4funcEi"<br class="">
+; CHECK-NOT: NULL<br class="">
+; CHECK-NOT: TAG<br class="">
----------------<br class="">
</span><span class="">dblaikie wrote:<br class="">
> Could write this as {{NULL|TAG}} (& update the other one nearby to do that for consistency). If you like.<br class="">
</span>Will do<br class="">
<span class=""><br class="">
================<br class="">
Comment at: test/DebugInfo/X86/inline-seldag-test.ll:14<br class="">
@@ -13,3 +13,1 @@<br class="">
<br class="">
-; CHECK: [[F:.*]]: DW_TAG_subprogram<br class="">
-; CHECK-NOT: DW_TAG<br class="">
----------------<br class="">
</span><span class="">dblaikie wrote:<br class="">
> I see you dropped the abs def checking in this case - why this case & not others?<br class="">
</span>Because in this case, noone else tries to match a TAG_subprogram, the test bellow is for an inline_subroutine.<br class="">
<br class="">
<a href="http://reviews.llvm.org/D5466" target="_blank" class="">http://reviews.llvm.org/D5466</a><br class="">
<br class="">
<br class="">
</blockquote></div><br class=""></div></div>
</div></blockquote></div><br class=""></body></html>