<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Fri, Sep 26, 2014 at 4:36 PM, Duncan P. N. Exon Smith <span dir="ltr"><<a href="mailto:dexonsmith@apple.com" target="_blank">dexonsmith@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">> On Sep 26, 2014, at 2:53 PM, Richard Smith <<a href="mailto:richard-llvm@metafoo.co.uk">richard-llvm@metafoo.co.uk</a>> wrote:<br>
><br>
> Author: rsmith<br>
> Date: Fri Sep 26 16:53:12 2014<br>
> New Revision: 218544<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=218544&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=218544&view=rev</a><br>
> Log:<br>
> Remove definition of LLVM_VERSION_INFO; this macro is not used by any of the<br>
> files in this directory. If it should be defined anywhere, it should be defined<br>
> when building lib/LTO/LTOCodeGenerator.cpp, but we've not had it defined there<br>
> for quite some time, so that doesn't really seem to be very important. (It also<br>
> would slow down the modules build by creating extra module variants.)<br>
><br>
> Modified:<br>
>    llvm/trunk/tools/lto/CMakeLists.txt<br>
>    llvm/trunk/tools/lto/Makefile<br>
<br>
</span>Your logic seems correct about it not working currently, but it looks<br>
like a bug that it's not included in `lto_get_version()`.<br>
<br>
Shouldn't we just fix it?</blockquote><div><br></div><div>Sure, if anyone cares.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">
> Modified: llvm/trunk/tools/lto/CMakeLists.txt<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/lto/CMakeLists.txt?rev=218544&r1=218543&r2=218544&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/lto/CMakeLists.txt?rev=218544&r1=218543&r2=218544&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/tools/lto/CMakeLists.txt (original)<br>
> +++ llvm/trunk/tools/lto/CMakeLists.txt Fri Sep 26 16:53:12 2014<br>
> @@ -6,8 +6,6 @@ set(LLVM_LINK_COMPONENTS<br>
>   Support<br>
>   )<br>
><br>
> -add_definitions( -DLLVM_VERSION_INFO=\"${PACKAGE_VERSION}\" )<br>
> -<br>
> set(SOURCES<br>
>   LTODisassembler.cpp<br>
>   lto.cpp<br>
><br>
> Modified: llvm/trunk/tools/lto/Makefile<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/lto/Makefile?rev=218544&r1=218543&r2=218544&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/lto/Makefile?rev=218544&r1=218543&r2=218544&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/tools/lto/Makefile (original)<br>
> +++ llvm/trunk/tools/lto/Makefile Fri Sep 26 16:53:12 2014<br>
> @@ -17,10 +17,6 @@ EXPORTED_SYMBOL_FILE = $(PROJ_SRC_DIR)/l<br>
><br>
> include $(LEVEL)/Makefile.common<br>
><br>
> -ifdef LLVM_VERSION_INFO<br>
> -CXX.Flags += -DLLVM_VERSION_INFO='"$(LLVM_VERSION_INFO)"'<br>
> -endif<br>
> -<br>
> ifeq ($(HOST_OS),Darwin)<br>
>     # Special hack to allow libLTO to have an offset version number.<br>
>     ifdef LLVM_LTO_VERSION_OFFSET<br>
><br>
<br>
</div></div></blockquote></div><br></div></div>