<div dir="ltr">Didn't know DenseMap had that member function. Thanks.</div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Sep 26, 2014 at 4:21 PM, Duncan P. N. Exon Smith <span dir="ltr"><<a href="mailto:dexonsmith@apple.com" target="_blank">dexonsmith@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5"><br>
> On Sep 26, 2014, at 3:27 PM, Rui Ueyama <<a href="mailto:ruiu@google.com">ruiu@google.com</a>> wrote:<br>
><br>
> Author: ruiu<br>
> Date: Fri Sep 26 17:27:42 2014<br>
> New Revision: 218548<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=218548&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=218548&view=rev</a><br>
> Log:<br>
> Fix crash bug on Windows.<br>
><br>
> Mutating the DenseMap here seems to cause the Windows executable<br>
> to crash. Don't use operator[] to access possibly nonexistent key.<br>
><br>
> Modified:<br>
>    lld/trunk/lib/Core/Resolver.cpp<br>
><br>
> Modified: lld/trunk/lib/Core/Resolver.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Core/Resolver.cpp?rev=218548&r1=218547&r2=218548&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Core/Resolver.cpp?rev=218548&r1=218547&r2=218548&view=diff</a><br>
> ==============================================================================<br>
> --- lld/trunk/lib/Core/Resolver.cpp (original)<br>
> +++ lld/trunk/lib/Core/Resolver.cpp Fri Sep 26 17:27:42 2014<br>
> @@ -305,8 +305,10 @@ void Resolver::markLive(const Atom *atom<br>
>   if (const DefinedAtom *defAtom = dyn_cast<DefinedAtom>(atom)) {<br>
>     for (const Reference *ref : *defAtom)<br>
>       markLive(ref->target());<br>
> -    for (const Atom *target : _reverseRef[defAtom])<br>
> -      markLive(target);<br>
> +    auto it = _reverseRef.find(defAtom);<br>
> +    if (it != _reverseRef.end())<br>
> +      for (const Atom *target : it->second)<br>
> +        markLive(target);<br>
<br>
</div></div>Should this just be:<br>
<br>
    for (const Atom *target : _reverseRef.lookup(defAtom))<br>
      markLive(target);<br>
<div class="HOEnZb"><div class="h5"><br>
?<br>
<br>
>   }<br>
> }<br>
><br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br>
</div></div></blockquote></div><br></div>