<div dir="ltr">You can use either one. We used to have to use register classes and have tablegen infer the type, but that changed some time ago, and tablegen can now find out type f64 should be used for FR64.</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 25, 2014 at 9:11 AM, Sanjay Patel <span dir="ltr"><<a href="mailto:spatel@rotateright.com" target="_blank">spatel@rotateright.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div>Hi all -<br><br></div>In this patch we use the "f64" value type for the source op in the pattern. The existing patterns that are similar use the "FR64" register class. Eg:<br> def : Pat<(v4f64 (X86VBroadcast FR64:$src)),<br> (VBROADCASTSDYrr (COPY_TO_REGCLASS FR64:$src, VR128))>;<br><br></div>Is there any functional difference or preference for this specification one way or the other?<br><div><br></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Sep 24, 2014 at 6:39 PM, Akira Hatanaka <span dir="ltr"><<a href="mailto:ahatanak@gmail.com" target="_blank">ahatanak@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Thanks, committed in r218431.</div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Sep 24, 2014 at 5:28 PM, Chandler Carruth <span dir="ltr"><<a href="mailto:chandlerc@google.com" target="_blank">chandlerc@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">LGTM.</div><div class="gmail_extra"><br><div class="gmail_quote"><div><div>On Wed, Sep 24, 2014 at 5:21 PM, Akira Hatanaka <span dir="ltr"><<a href="mailto:ahatanak@gmail.com" target="_blank">ahatanak@gmail.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><div dir="ltr"><div><p style="margin:0px">The attached patch adds a pattern for X86Broadcast. This is the error message I'm currently seeing when I compile the test case:<br></p><p style="margin:0px;font-size:11px;font-family:Menlo"><span style="font-family:arial;font-size:small"><br></span></p><p style="margin:0px;font-size:11px;font-family:Menlo">LLVM ERROR: Cannot select: 0x7fda11827200: v2f64 = X86ISD::VBROADCAST 0x7fda12024918 [ORD=2] [ID=14]</p>
<p style="margin:0px;font-size:11px;font-family:Menlo"> 0x7fda12024918: f64,ch = load 0x7fda1150bcd0, 0x7fda12024600, 0x7fda12025050<LD8[ConstantPool]> [ORD=2] [ID=12]</p>
<p style="margin:0px;font-size:11px;font-family:Menlo"> 0x7fda12024600: i64 = X86ISD::WrapperRIP 0x7fda12024c30 [ID=10]</p>
<p style="margin:0px;font-size:11px;font-family:Menlo"> 0x7fda12024c30: i64 = TargetConstantPool<double -1.000000e+00> 0 [ID=8]</p>
<p style="margin:0px;font-size:11px;font-family:Menlo"> 0x7fda12025050: i64 = undef [ID=2]</p></div><div><br></div>This fixes PR21050.</div>
<br></div></div>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>
</blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>
</div></div></blockquote></div><br></div>