<p dir="ltr">Hi Kaelyn, </p>
<p dir="ltr">As Renato emailed that he was working on this 5 minutes after you reported the problem, do you not think this revert was slightly premature? Or is there context (irc?) I'm missing?</p>
<p dir="ltr">Cheers,</p>
<p dir="ltr">James</p>
<div class="gmail_quote">On 24 Sep 2014 19:14, "Kaelyn Takata" <<a href="mailto:rikka@google.com">rikka@google.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rikka<br>
Date: Wed Sep 24 13:00:17 2014<br>
New Revision: 218397<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=218397&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=218397&view=rev</a><br>
Log:<br>
Revert "Report endianness in output of {dwarf, obj}dump"<br>
<br>
This reverts commit r218391 as it depends on r218388 and r218389<br>
<br>
Removed:<br>
llvm/trunk/test/tools/llvm-dwarfdump/AArch64/little-endian-dump.ll<br>
llvm/trunk/test/tools/llvm-dwarfdump/ARM/little-endian-dump.ll<br>
Modified:<br>
llvm/trunk/include/llvm/Object/ELFObjectFile.h<br>
llvm/trunk/test/tools/llvm-dwarfdump/AArch64/big-endian-dump.ll<br>
llvm/trunk/test/tools/llvm-dwarfdump/ARM/big-endian-dump.ll<br>
<br>
Modified: llvm/trunk/include/llvm/Object/ELFObjectFile.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Object/ELFObjectFile.h?rev=218397&r1=218396&r2=218397&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Object/ELFObjectFile.h?rev=218397&r1=218396&r2=218397&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/Object/ELFObjectFile.h (original)<br>
+++ llvm/trunk/include/llvm/Object/ELFObjectFile.h Wed Sep 24 13:00:17 2014<br>
@@ -855,7 +855,6 @@ uint8_t ELFObjectFile<ELFT>::getBytesInA<br>
<br>
template <class ELFT><br>
StringRef ELFObjectFile<ELFT>::getFileFormatName() const {<br>
- bool IsLittleEndian = ELFT::TargetEndianness == support::little;<br>
switch (EF.getHeader()->e_ident[ELF::EI_CLASS]) {<br>
case ELF::ELFCLASS32:<br>
switch (EF.getHeader()->e_machine) {<br>
@@ -864,7 +863,7 @@ StringRef ELFObjectFile<ELFT>::getFileFo<br>
case ELF::EM_X86_64:<br>
return "ELF32-x86-64";<br>
case ELF::EM_ARM:<br>
- return (IsLittleEndian ? "ELF32-arm-little" : "ELF32-arm-big");<br>
+ return "ELF32-arm";<br>
case ELF::EM_HEXAGON:<br>
return "ELF32-hexagon";<br>
case ELF::EM_MIPS:<br>
@@ -884,7 +883,7 @@ StringRef ELFObjectFile<ELFT>::getFileFo<br>
case ELF::EM_X86_64:<br>
return "ELF64-x86-64";<br>
case ELF::EM_AARCH64:<br>
- return (IsLittleEndian ? "ELF64-aarch64-little" : "ELF64-aarch64-big");<br>
+ return "ELF64-aarch64";<br>
case ELF::EM_PPC64:<br>
return "ELF64-ppc64";<br>
case ELF::EM_S390:<br>
<br>
Modified: llvm/trunk/test/tools/llvm-dwarfdump/AArch64/big-endian-dump.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-dwarfdump/AArch64/big-endian-dump.ll?rev=218397&r1=218396&r2=218397&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-dwarfdump/AArch64/big-endian-dump.ll?rev=218397&r1=218396&r2=218397&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/tools/llvm-dwarfdump/AArch64/big-endian-dump.ll (original)<br>
+++ llvm/trunk/test/tools/llvm-dwarfdump/AArch64/big-endian-dump.ll Wed Sep 24 13:00:17 2014<br>
@@ -1,7 +1,5 @@<br>
; RUN: llc -O0 -filetype=obj -o %t1 < %s<br>
-; RUN: llvm-dwarfdump %t1 | FileCheck %s<br>
-<br>
-; CHECK: file format ELF64-aarch64-big<br>
+; RUN: llvm-dwarfdump %t1<br>
<br>
target datalayout = "E-m:e-i64:64-i128:128-n32:64-S128"<br>
target triple = "aarch64_be-none--eabi"<br>
<br>
Removed: llvm/trunk/test/tools/llvm-dwarfdump/AArch64/little-endian-dump.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-dwarfdump/AArch64/little-endian-dump.ll?rev=218396&view=auto" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-dwarfdump/AArch64/little-endian-dump.ll?rev=218396&view=auto</a><br>
==============================================================================<br>
--- llvm/trunk/test/tools/llvm-dwarfdump/AArch64/little-endian-dump.ll (original)<br>
+++ llvm/trunk/test/tools/llvm-dwarfdump/AArch64/little-endian-dump.ll (removed)<br>
@@ -1,18 +0,0 @@<br>
-; RUN: llc -O0 -filetype=obj -o %t1 < %s<br>
-; RUN: llvm-dwarfdump %t1 | FileCheck %s<br>
-<br>
-; CHECK: file format ELF64-aarch64-little<br>
-<br>
-target datalayout = "e-m:e-i64:64-i128:128-n32:64-S128"<br>
-target triple = "aarch64-none--eabi"<br>
-<br>
-!<a href="http://llvm.dbg.cu" target="_blank">llvm.dbg.cu</a> = !{!0}<br>
-!llvm.module.flags = !{!3, !4}<br>
-!llvm.ident = !{!5}<br>
-<br>
-!0 = metadata !{i32 786449, metadata !1, i32 12, metadata !"clang version 3.6.0 ", i1 false, metadata !"", i32 0, metadata !2, metadata !2, metadata !2, metadata !2, metadata !2, metadata !"", i32 1} ; [ DW_TAG_compile_unit ] [/a/empty.c] [DW_LANG_C99]<br>
-!1 = metadata !{metadata !"empty.c", metadata !"/a"}<br>
-!2 = metadata !{}<br>
-!3 = metadata !{i32 2, metadata !"Dwarf Version", i32 4}<br>
-!4 = metadata !{i32 2, metadata !"Debug Info Version", i32 1}<br>
-!5 = metadata !{metadata !"clang version 3.6.0 "}<br>
<br>
Modified: llvm/trunk/test/tools/llvm-dwarfdump/ARM/big-endian-dump.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-dwarfdump/ARM/big-endian-dump.ll?rev=218397&r1=218396&r2=218397&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-dwarfdump/ARM/big-endian-dump.ll?rev=218397&r1=218396&r2=218397&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/tools/llvm-dwarfdump/ARM/big-endian-dump.ll (original)<br>
+++ llvm/trunk/test/tools/llvm-dwarfdump/ARM/big-endian-dump.ll Wed Sep 24 13:00:17 2014<br>
@@ -1,7 +1,5 @@<br>
; RUN: llc -O0 -filetype=obj -o %t1 < %s<br>
-; RUN: llvm-dwarfdump %t1 | FileCheck %s<br>
-<br>
-; CHECK: file format ELF32-arm-big<br>
+; RUN: llvm-dwarfdump %t1<br>
<br>
target datalayout = "E-m:e-p:32:32-i64:64-v128:64:128-n32-S64"<br>
target triple = "armebv8-none--eabi"<br>
<br>
Removed: llvm/trunk/test/tools/llvm-dwarfdump/ARM/little-endian-dump.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-dwarfdump/ARM/little-endian-dump.ll?rev=218396&view=auto" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-dwarfdump/ARM/little-endian-dump.ll?rev=218396&view=auto</a><br>
==============================================================================<br>
--- llvm/trunk/test/tools/llvm-dwarfdump/ARM/little-endian-dump.ll (original)<br>
+++ llvm/trunk/test/tools/llvm-dwarfdump/ARM/little-endian-dump.ll (removed)<br>
@@ -1,20 +0,0 @@<br>
-; RUN: llc -O0 -filetype=obj -o %t1 < %s<br>
-; RUN: llvm-dwarfdump %t1 | FileCheck %s<br>
-<br>
-; CHECK: file format ELF32-arm-little<br>
-<br>
-target datalayout = "e-m:e-p:32:32-i64:64-v128:64:128-n32-S64"<br>
-target triple = "armv8-none--eabi"<br>
-<br>
-!<a href="http://llvm.dbg.cu" target="_blank">llvm.dbg.cu</a> = !{!0}<br>
-!llvm.module.flags = !{!3, !4, !5, !6}<br>
-!llvm.ident = !{!7}<br>
-<br>
-!0 = metadata !{i32 786449, metadata !1, i32 12, metadata !"clang version 3.6.0 ", i1 false, metadata !"", i32 0, metadata !2, metadata !2, metadata !2, metadata !2, metadata !2, metadata !"", i32 1} ; [ DW_TAG_compile_unit ] [/a/empty.c] [DW_LANG_C99]<br>
-!1 = metadata !{metadata !"empty.c", metadata !"/a"}<br>
-!2 = metadata !{}<br>
-!3 = metadata !{i32 2, metadata !"Dwarf Version", i32 4}<br>
-!4 = metadata !{i32 2, metadata !"Debug Info Version", i32 1}<br>
-!5 = metadata !{i32 1, metadata !"wchar_size", i32 4}<br>
-!6 = metadata !{i32 1, metadata !"min_enum_size", i32 4}<br>
-!7 = metadata !{metadata !"clang version 3.6.0 "}<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>