<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">I don’t think it would have shown up as a leak. The bad code was adding values to a DenseMap and never clever them out between functions. I don’t see how lsan could have detected that.<div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Sep 24, 2014, at 4:23 PM, Kostya Serebryany <<a href="mailto:kcc@google.com" class="">kcc@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><br class="Apple-interchange-newline"><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div class="gmail_quote" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">On Wed, Sep 24, 2014 at 4:21 PM, Eric Christopher<span class="Apple-converted-space"> </span><span dir="ltr" class=""><<a href="mailto:echristo@gmail.com" target="_blank" class="">echristo@gmail.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><div class="HOEnZb"><div class="h5">On Wed, Sep 24, 2014 at 4:20 PM, Kostya Serebryany <<a href="mailto:kcc@google.com" class="">kcc@google.com</a>> wrote:<br class="">><br class="">><br class="">> On Wed, Sep 24, 2014 at 2:47 PM, Eric Christopher <<a href="mailto:echristo@gmail.com" class="">echristo@gmail.com</a>><br class="">> wrote:<br class="">>><br class="">>> On Wed, Sep 24, 2014 at 1:16 AM, Renato Golin <<a href="mailto:renato.golin@linaro.org" class="">renato.golin@linaro.org</a>><br class="">>> wrote:<br class="">>> > On 23 September 2014 18:56, Bob Wilson <<a href="mailto:bob.wilson@apple.com" class="">bob.wilson@apple.com</a>> wrote:<br class="">>> >> We’re seeing significant regressions in memory usage. I think you<br class="">>> >> forgot to clear the PreferredExtendType DenseMap that you added here.<br class="">>> ><br class="">>> > Seems we're missing some valgrind / sanitizer buildbots to check that<br class="">>> > automatically?<br class="">>> ><br class="">>><br class="">>><span class="Apple-converted-space"> </span><a href="http://lab.llvm.org:8011/builders/clang-x86_64-linux-vg" target="_blank" class="">http://lab.llvm.org:8011/builders/clang-x86_64-linux-vg</a><br class="">>><br class="">>> which appears to be having problems.<br class="">>><br class="">>> I know that Kostya has some sanitizer bots, but I'm not sure what the<br class="">>> status is there.<br class="">><br class="">><br class="">> We have two bots:<br class="">><span class="Apple-converted-space"> </span><a href="http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux" target="_blank" class="">http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux</a><br class="">><span class="Apple-converted-space"> </span><a href="http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/" target="_blank" class="">http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/</a><br class="">> The second one is red at the moment with some (fresh?) msan reports.<br class="">> What is the problem here?<br class="">><br class=""><br class=""></div></div>Aha.<br class=""><br class="">Anyhow as of r218101 we were leaking quite a bit of memory. I don't<br class="">know if the sanitizers reported it or not.<br class=""></blockquote><div class=""><br class=""></div><div class="">lsan is silent. repro? </div><div class=""><br class=""></div><div class=""> </div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><br class="">-eric<br class=""><br class="">>><br class="">>><br class="">>> -eric<br class="">><br class="">></blockquote></div></div></blockquote></div><br class=""></div></body></html>