<div dir="ltr">No - it's still valid, since SearchForAddress can return zero.<div><br></div><div>- Lang.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Sep 23, 2014 at 11:12 AM, Duncan P. N. Exon Smith <span dir="ltr"><<a href="mailto:dexonsmith@apple.com" target="_blank">dexonsmith@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br>
> On 2014-Sep-21, at 10:21, Lang Hames <<a href="mailto:lhames@gmail.com">lhames@gmail.com</a>> wrote:<br>
><br>
> Author: lhames<br>
> Date: Sun Sep 21 12:21:56 2014<br>
> New Revision: 218220<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=218220&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=218220&view=rev</a><br>
> Log:<br>
> Remove redundant if test.<br>
><br>
><br>
> Modified:<br>
>    llvm/trunk/lib/ExecutionEngine/RTDyldMemoryManager.cpp<br>
><br>
> Modified: llvm/trunk/lib/ExecutionEngine/RTDyldMemoryManager.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/RTDyldMemoryManager.cpp?rev=218220&r1=218219&r2=218220&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/RTDyldMemoryManager.cpp?rev=218220&r1=218219&r2=218220&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/lib/ExecutionEngine/RTDyldMemoryManager.cpp (original)<br>
> +++ llvm/trunk/lib/ExecutionEngine/RTDyldMemoryManager.cpp Sun Sep 21 12:21:56 2014<br>
> @@ -265,10 +265,7 @@ uint64_t RTDyldMemoryManager::getSymbolA<br>
><br>
>   // If we Name did not require demangling, or we failed to find the demangled<br>
>   // name, try again without demangling.<br>
> -  if (void *Ptr = sys::DynamicLibrary::SearchForAddressOfSymbol(NameStr))<br>
> -    return (uint64_t)Ptr;<br>
> -<br>
> -  return 0;<br>
> +  return (uint64_t)sys::DynamicLibrary::SearchForAddressOfSymbol(NameStr);<br>
> }<br>
><br>
> void *RTDyldMemoryManager::getPointerToNamedFunction(const std::string &Name,<br>
><br>
<br>
</span>Should that comment be removed too?<br>
</blockquote></div><br></div>