<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Sep 20, 2014 at 9:13 PM, Yaron Keren <span dir="ltr"><<a href="mailto:yaron.keren@gmail.com" target="_blank">yaron.keren@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: yrnkrn<br>
Date: Sat Sep 20 23:13:45 2014<br>
New Revision: 218197<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=218197&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=218197&view=rev</a><br>
Log:<br>
Silence these C4715 warnings from Visual C++ (NFC)<br>
<br>
llvm\tools\lld\lib\readerwriter\macho\macholinkingcontext.cpp(647):<br>
warning C4715: 'lld::MachOLinkingContext::exportSymbolNamed' :<br>
not all control paths return a value<br>
<br>
llvm\tools\lld\lib\readerwriter\macho\machonormalizedfilefromatoms.cpp(723):<br>
warning C4715: '`anonymous namespace'::Util::getSymbolTableRegion' :<br>
not all control paths return a value<br>
<br>
While all enum values do appear in the switch, an uninitialized or corrupted<br>
enum variable would not be caught without the default: case in the switch.<br></blockquote><div><br></div><div>Usually the right way to deal with this is to put the unreachable /after/ the switch, rather than adding a default (& you don't need a return after an unreachable in any context)<br><br>Your change will probably cause a -Wcovered-switch-default warning/break, unfortunately.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
Modified:<br>
    lld/trunk/lib/ReaderWriter/MachO/MachOLinkingContext.cpp<br>
    lld/trunk/lib/ReaderWriter/MachO/MachONormalizedFileFromAtoms.cpp<br>
<br>
Modified: lld/trunk/lib/ReaderWriter/MachO/MachOLinkingContext.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/MachO/MachOLinkingContext.cpp?rev=218197&r1=218196&r2=218197&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/MachO/MachOLinkingContext.cpp?rev=218197&r1=218196&r2=218197&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/lib/ReaderWriter/MachO/MachOLinkingContext.cpp (original)<br>
+++ lld/trunk/lib/ReaderWriter/MachO/MachOLinkingContext.cpp Sat Sep 20 23:13:45 2014<br>
@@ -643,6 +643,8 @@ bool MachOLinkingContext::exportSymbolNa<br>
     return _exportedSymbols.count(sym);<br>
   case ExportMode::blackList:<br>
     return !_exportedSymbols.count(sym);<br>
+  default:<br>
+    llvm_unreachable("_exportMode unknown enum value");<br>
   }<br>
 }<br>
<br>
<br>
Modified: lld/trunk/lib/ReaderWriter/MachO/MachONormalizedFileFromAtoms.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/MachO/MachONormalizedFileFromAtoms.cpp?rev=218197&r1=218196&r2=218197&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/MachO/MachONormalizedFileFromAtoms.cpp?rev=218197&r1=218196&r2=218197&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/lib/ReaderWriter/MachO/MachONormalizedFileFromAtoms.cpp (original)<br>
+++ lld/trunk/lib/ReaderWriter/MachO/MachONormalizedFileFromAtoms.cpp Sat Sep 20 23:13:45 2014<br>
@@ -719,6 +719,9 @@ std::error_code Util::getSymbolTableRegi<br>
       return std::error_code();<br>
     }<br>
     break;<br>
+  default:<br>
+    llvm_unreachable("atom->scope() unknown enum value");<br>
+    return std::error_code();<br>
   }<br>
 }<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>