<div dir="ltr">Looks like this might've regressed some debug scenarios:<br><br><a href="http://lab.llvm.org:8011/builders/clang-x86_64-ubuntu-gdb-75/builds/17377">http://lab.llvm.org:8011/builders/clang-x86_64-ubuntu-gdb-75/builds/17377</a><br><br>(could be r218040, but it seems like the less likely candidate of the two on the blame list)</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 18, 2014 at 2:38 AM, Frederic Riss <span dir="ltr"><<a href="mailto:friss@apple.com" target="_blank">friss@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: friss<br>
Date: Thu Sep 18 04:38:23 2014<br>
New Revision: 218041<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=218041&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=218041&view=rev</a><br>
Log:<br>
Always emit DW_AT_declaration attribute when the variable isn't a definition.<br>
<br>
Summary:<br>
This doesn't show up today as we don't emit decalration only variables. This<br>
will be tested when the followup patches implementing import of forward<br>
declared entities lands in clang.<br>
<br>
Reviewers: echristo, dblaikie, aprantl<br>
<br>
Subscribers: llvm-commits<br>
<br>
Differential Revision: <a href="http://reviews.llvm.org/D5382" target="_blank">http://reviews.llvm.org/D5382</a><br>
<br>
Modified:<br>
    llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp<br>
<br>
Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp?rev=218041&r1=218040&r2=218041&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp?rev=218041&r1=218040&r2=218041&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp (original)<br>
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp Thu Sep 18 04:38:23 2014<br>
@@ -1670,6 +1670,9 @@ void DwarfCompileUnit::createGlobalVaria<br>
       DD->addArangeLabel(SymbolCU(this, Sym));<br>
       addOpAddress(*Loc, Sym);<br>
     }<br>
+    // A static member's declaration is already flagged as such.<br>
+    if (!SDMDecl.Verify() && !GV.isDefinition())<br>
+      addFlag(*VariableDIE, dwarf::DW_AT_declaration);<br>
     // Do not create specification DIE if context is either compile unit<br>
     // or a subprogram.<br>
     if (GVContext && GV.isDefinition() && !GVContext.isCompileUnit() &&<br>
@@ -1678,9 +1681,6 @@ void DwarfCompileUnit::createGlobalVaria<br>
       VariableSpecDIE = &createAndAddDIE(dwarf::DW_TAG_variable, UnitDie);<br>
       addDIEEntry(*VariableSpecDIE, dwarf::DW_AT_specification, *VariableDIE);<br>
       addBlock(*VariableSpecDIE, dwarf::DW_AT_location, Loc);<br>
-      // A static member's declaration is already flagged as such.<br>
-      if (!SDMDecl.Verify())<br>
-        addFlag(*VariableDIE, dwarf::DW_AT_declaration);<br>
     } else {<br>
       addBlock(*VariableDIE, dwarf::DW_AT_location, Loc);<br>
     }<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>